Don't re-break body parts on non-damaging hits

[Coolthulhu]

Mending effect should only be removed if the hit on the mending body part actually dealt damage.

Also adjusted mend intensity factor: with 36000 factor, the "mostly mended" description was shown for twice as long as the descriptions before it. With 48000, each description should be shown for the same length of time.

[kevingranade]

Mending effect should only be removed if the hit on the mending body part actually dealt damage.

This occurring 'on hit' instead of 'on damage' is intentional, a broken limb is fragile enough that hits that wouldn't normally cause damage are enough to disturb the healing process.

[AlecWhite]

a broken limb is fragile enough that hits that wouldn't normally cause damage are enough to disturb the healing process.

Unless it is something like a hulk throwing you through a wall, or some very high impact special attack, is very counter-intuitive and borderline unrealistic.

You would need to have a very bad fitted splint or cast for any kind of hit to affect the healing process of a broken limb to that degree. And anyone who has broken limb, and tripped/felt down can tell you that you would need to get a very good hit for it to affect the broken limb.

[Tsunder]

This occurring 'on hit' instead of 'on damage' is intentional, a broken limb is fragile enough that hits that wouldn't normally cause damage are enough to disturb the healing process.

This is poor design, as there are things that deal 0 damage, poorly thrown pebbles, hallucinations, arrows that bounce off armor... flesh in the splints, bone even, is fairly well set in place.

schizophrenics at the moment have recovery times an order of magnitude longer due to limbs resetting from hallucinations, hits from imaginary enemies should not have real effects on physical healing.

Unless it is something like a hulk throwing you through a wall, or some very high impact special attack, is very counter-intuitive and borderline unrealistic.

minor flesh wounds from glass shards, papercuts, would not even disturb healing.

survivors/npcs being able to heal from bullet-ridden limbs to full health in the course of one or two nights rest is testament to their durability /joke

[kevingranade]

Working as intended in general.
Targeted fixes to the healing process being reset by hallucinations or a nuanced fix to handle non-damaging attacks vs negated damage are welcome.

The rationale for changing the mend factor is also strange, they should be the same, based on what?

[Coolthulhu]

Working as intended in general.

Full plate armor not stopping rat and mosquito bites from re-breaking limbs is working as intended? Acid spit blocked entirely by hazmat but still re-breaking limbs is working as intended? BB bullets stopped by forcefield, fire stopped by isolating armor?
Is it intended to have more edge cases than sensibly handled cases?
I certainly did not intend it to be this stupid when I implemented it. Those were just honest mistakes.

The rationale for changing the mend factor is also strange, they should be the same, based on what?

It's just the message timing. I fucked up the messages: it was supposed to be 33% time "started mending", then 33% of the time "partly mended", then finally 33% "mostly mended", but I got the math wrong and it ended up 25%/25%/50%, which is confusing and unlike other similar effects (infection).

[Chronitonity]

Current limb healing is neither realistic nor fun when your limb breaks huh

[saltmummy626]

Your logic is spot on there kevin.

"yes mr. johnson, your arm is healing really well. We just have to administer this shot of antibiotics to- woops, arms broken again. Looks like you'll have to wait another month to go back to work. See you then for another dose of antibiotics!"

"yeah, I got my cast off yesterday. The doc says I can't lift anything ove-" stiff breeze "OH GOD MY ARM!"

"Too bad my leg is busted. Sure is nice having this thick steel piece of metal to protect it from further harm. Hey, whats that kid doing with that BB gun?" bink leg rebreaks

The logical fallacies you display on a regular basis disturb me greatly.

oh, and lets not forget the bit where under this bug, your hallucinations can also reset the mend timer when they manage to hit a broken limb.

[DangerNoodle]

This is a terrible idea, @kevingranade.

This is neither realistic nor even remotely beneficial to gameplay, and it concerns me that you think it to be either, especially when a fellow developer has already stated it is a bug, and that they have taken it as their responsibility to fix what they consider a mistake they left over.

[saltmummy626]

Something else that's bothering me about this.
Coolthulhu does something.
Coolthulhu notices or is notified that something isn't working correctly.
Coolthulhu tries to fix a mistake in the thing he did.
Kevin says that it (a bug) is working as intended. As Coolthulhu intended it.
Except he didn't intend for it to do that. Coolthulhu wants to fix a bug, but he can't because apparently he intended that bug to exist in the first place, according to kevin?

[DangerNoodle]

Kevin has made this error in the past, has he not?