Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRenamed Vacutainer© to Blood draw kit. #21486
Conversation
Treah
added some commits
Jul 24, 2017
This comment has been minimized.
This comment has been minimized.
|
Forgot to add all the changes that I did with a misplaced git add command. Corrected and pushed. |
Treah
changed the title
Renamed Vacutainer to Blood draw kit.
Renamed Vacutainer© to Blood draw kit.
Jul 24, 2017
This comment has been minimized.
This comment has been minimized.
|
If you change the item id you'll break savegames. |
This comment has been minimized.
This comment has been minimized.
|
Would also affect tile sets. |
This comment has been minimized.
This comment has been minimized.
|
Well damn... The id was using the same name so there really wouldn't be a good way to remove the offending copyrighted word without doing that. Just renaming it only changes how its viewed in the game itself but not code and possibly not the item browser where the infringement was lobbied against. Looking on the browser changing the name would probably work for that site at least however it would still be using the name in the code. |
This comment has been minimized.
This comment has been minimized.
|
Not copyright, trademark. They REALLY have no business complaining about us using trademarked terms in game internals, that's not how trademark works. |
This comment has been minimized.
This comment has been minimized.
|
Then is this whole thing of adding the ® is still needed? |
This comment has been minimized.
This comment has been minimized.
|
No, it never was, they were just making baseless demands. We're not infringing on their trademark in the first place. |
This comment has been minimized.
This comment has been minimized.
|
Ok ill run though this again tonight and change the Id's back to keep from breaking saves. Ill leave the action as is in the PR however as it is better and should not cause any issues. |
This comment has been minimized.
This comment has been minimized.
|
Changed the item id's back and tested this out locally. Seams to be ok and only broke my game that I had tested before with the old id. Please let me know if anyone gets any errors after applying this if its merged. |
Treah commentedJul 24, 2017
Changed the name to be more descriptive of what this item actually does and is used for. Changed references to the item in the text along with changing its action from VACUTAINER to BLOOD_DRAW to clear up again what this action is.
The old name is a bit confusing and has problems with translations and the end user understanding its purpose.
Also the name of the item is copyrighted by a company that requested it be changed when looking at the item database on chestholes site. Issue #21459