Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Vacutainer© to Blood draw kit. #21486

Merged
merged 3 commits into from Jul 30, 2017

Conversation

Projects
None yet
5 participants
@Treah
Copy link
Contributor

commented Jul 24, 2017

Changed the name to be more descriptive of what this item actually does and is used for. Changed references to the item in the text along with changing its action from VACUTAINER to BLOOD_DRAW to clear up again what this action is.

The old name is a bit confusing and has problems with translations and the end user understanding its purpose.

Also the name of the item is copyrighted by a company that requested it be changed when looking at the item database on chestholes site. Issue #21459

Treah added some commits Jul 24, 2017

@Treah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2017

Forgot to add all the changes that I did with a misplaced git add command. Corrected and pushed.

@Treah Treah changed the title Renamed Vacutainer to Blood draw kit. Renamed Vacutainer© to Blood draw kit. Jul 24, 2017

@kevingranade

This comment has been minimized.

Copy link
Member

commented Jul 26, 2017

If you change the item id you'll break savegames.
We have some migration code, but we could also just leave the id as it is.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2017

Would also affect tile sets.

@Treah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2017

Well damn... The id was using the same name so there really wouldn't be a good way to remove the offending copyrighted word without doing that. Just renaming it only changes how its viewed in the game itself but not code and possibly not the item browser where the infringement was lobbied against.

Looking on the browser changing the name would probably work for that site at least however it would still be using the name in the code.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

Not copyright, trademark. They REALLY have no business complaining about us using trademarked terms in game internals, that's not how trademark works.

@AlecWhite

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

Then is this whole thing of adding the ® is still needed?

@kevingranade

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

No, it never was, they were just making baseless demands. We're not infringing on their trademark in the first place.

@Treah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

Ok ill run though this again tonight and change the Id's back to keep from breaking saves. Ill leave the action as is in the PR however as it is better and should not cause any issues.

Changed ID's to be save compaitible back to vacutainer. Kept iuse act…
…ions to be more descriptive and kept item name as blood draw kit.
@Treah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2017

Changed the item id's back and tested this out locally. Seams to be ok and only broke my game that I had tested before with the old id. Please let me know if anyone gets any errors after applying this if its merged.

@Coolthulhu Coolthulhu self-assigned this Jul 30, 2017

@Coolthulhu Coolthulhu merged commit cb52f12 into CleverRaven:master Jul 30, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 22.87%
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.