Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMake metabolic mutations more interesting #21524
Conversation
codemime
reviewed
Aug 2, 2017
| thirst_rate = std::min( thirst_rate, std::max( 0.5f, thirst_rate * 0.5f ) ); | ||
| // Recycler won't help much with mutant metabolism - it is indended for human one | ||
| hunger_rate = std::min( hunger_rate, std::max( 0.5f, hunger_rate - 0.5f ) ); | ||
| thirst_rate = std::min( thirst_rate, std::max( 0.5f, thirst_rate - 0.5f ) ); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Coolthulhu
Aug 4, 2017
Author
Contributor
The problem is, the maximum value changes too.
Clamp expects min <= max, which can't be guaranteed here: hunger_rate - 0.5 can be above or below 0.5.
Coolthulhu
changed the title
[CR]Make metabolic mutations more interesting
Make metabolic mutations more interesting
Aug 4, 2017
Rivet-the-Zombie
merged commit beeff69
into
CleverRaven:master
Aug 5, 2017
BevapDin
reviewed
Sep 15, 2017
| // But mouth encumberance interferes. | ||
| stamina_recovery += std::max( 1.0f, 10.0f - ( encumb( bp_mouth ) / 10.0f ) ); | ||
| // Mutated stamina works even when winded | ||
| float stamina_multiplier = ( !has_effect( effect_winded ) ? 1.0f : 0.0f ) + |
This comment has been minimized.
This comment has been minimized.
BevapDin
Sep 15, 2017
Contributor
This ternary with the negated condition is slightly confusing. It would be cleared without the negation (and inverted results) as has_effect() ? 0 : 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Coolthulhu commentedJul 31, 2017
Changed two really bad mutation lines into something worth considering keeping:
Fast metabolism mutation line gains a boost to stamina regeneration:
This bonus is applied even during "winded" effect, unlike regular human stamina regeneration.
However it does not skip penalties for mouth encumbrance - can't really fuel that super metabolism without oxygen. This sets it apart from the bionic, which works regardless of masks.
Cold blooded line gains low metabolism. After all, not maintaining body temperature means less work to stay alive.
The lowest level cold blooded becomes as effective as Light Eater (33% less food). All above it become even better: 50%.
Also some minor, moderately related changes: