Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change crossbow firing skills to match related firearms. #21545

Merged

Conversation

Projects
None yet
5 participants
@kevingranade
Copy link
Member

commented Aug 3, 2017

As mentioned a few times previously, the act of firing a crossbow doesn't bear any resemblance to the act of firing a bow, so using the same skill for both is nonsense.

Additionally, this provides a means to train various firearm skills without having to resort to expending valuable firearm rounds.

Thanks to @DangerNoodle for reminding me to get around to this in #21538

@kevingranade kevingranade changed the title Change crossbow firing skills to match related firearms instead of ar… Change crossbow firing skills to match related firearms. Aug 3, 2017

@@ -840,7 +840,7 @@
"price" : 324000, "//" : "Modern crossbows can come in anywhere from $300 to $2K. Large plus Antique = expensive.",
"material" : ["iron", "wood"],
"flags" : ["FIRE_TWOHAND", "STR_RELOAD", "PRIMITIVE_RANGED_WEAPON", "TRADER_AVOID"],
"skill" : "archery",
"skill" : "rifle",

This comment has been minimized.

Copy link
@kevingranade

kevingranade Aug 3, 2017

Author Member

Possibly switch to launcher instead of rifle? I'm abivalent.

This comment has been minimized.

Copy link
@Coolthulhu

Coolthulhu Aug 3, 2017

Contributor

Miniguns are rifles and not launchers and they're less similar to rifles than big xbows to small ones.

This comment has been minimized.

Copy link
@kevingranade

kevingranade Aug 3, 2017

Author Member

The aspects I'm thinking of are bulk, weight and inaccuracy, Gantz has all of thse in spades, it's essentially a siege engine you can barely carry.

Basically if no one has an argument for switching it to launcher I'll leave it using the rifle skill :)

Honestly the minigun probably shouldn't use rifle either, but I don't think launcher is any better, nothing really fits at all.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2017

You took the point I presented in that pull request, and went in the absolute opposite direction.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Aug 3, 2017

I agree that crossbows are operated in a rifles manner, not bows. Both should be raised up to head, stock should rest at the shoulder. Bows are aimed and fired in a different manner.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2017

Very well then. It at least will be closer to consistent than current handling.

Reminder that Vehicle Additions Pack has the scopio ballista, and that More Survival Tools has the makeshift crossbow.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2017

In addition, remember that professions that start with crossbows will like have archery skill, this will have to be changed.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 6cd159f into CleverRaven:master Aug 4, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 23.021%
Details
gorgon-ghprb Build finished.
Details

@kevingranade kevingranade deleted the kevingranade:crossbows-arent-bows branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.