Crossbow firing skill update, part 2

[DangerNoodle]

This pull request updates the crossbow items in mods to be consistent with recent changes to comparable weapons, and updates the skills of professions that start with these weapons.

For the scorpion ballista in Blaze's mod, I went with rifle skill in the same way the huge crossbow. I was uncertain whether launcher would apply to it, but the name implies it is a light, Roman style ballista.

I had mentioned in #21545 that these changes were neglected.

Question though. What about recipe skills? Many require archery, but making a bow for a crossbow is closer to the subject of archery than pointing and loosing a bolt, if the archery skill also covers bowyery.

[kevingranade]

I had mentioned in #21545 <#21545> that these changes were neglected. On Aug 4, 2017 10:52 AM, "DangerNoodle" <notifications@github.com> wrote: I had mentioned in #21545 <#21545> that these changes were neglected. I was working on these locally, but did not have time to complete the changes before @rivet pulled the trigger on the PR. Question though. What about recipe skills? Many require archery, but making a bow for a crossbow is closer to the subject of archery than pointing and loosing a bolt, if the archery skill also covers bowyery. Archery as a crafting skill was already an awkward matchup and this strains things further. The only valid options I see are either change them from archery to mechanics or leave them using archery. I'm leaning toward the former, but don't have a strong opinion about it.

[DangerNoodle]

I was working on these locally, but did not have time to complete the changes before @rivet pulled the trigger on the PR.

My apologies then.

Archery as a crafting skill was already an awkward matchup and this strains things further. The only valid options I see are either change them from archery to mechanics or leave them using archery. I'm leaning toward the former, but don't have a strong opinion about it.

Changing to weapon skill would be consistent with other weapon recipes that use their related skills, but it it feasible the fabrication plus familiarity with that class of firearm is a standin for familiarity with gunsmithing specifically. I suppose it could stay archery then, with fabrication plus archery being a standin for bowyery, but likewise I have no strong opinion on the subject.

[DangerNoodle]

This should be ready, unless there is anything wrong with it?

The delay caused by a premature merge is unfortunate, and it caused me to incorrectly direct blame at Kevin when he was in the process of implementing these changes, when the only error made was not remembering to do so on first commit.

[kevingranade]

The delay is not a big deal, and you shouldn't be directing blame at anyone in this project, ever.
Please show some patience with the development process.

[DangerNoodle]

My apologies then.