Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRare martial art books spawn #21560
Conversation
angoddu
reviewed
Aug 7, 2017
| [ "plays_book", 30 ], | ||
| [ "poetry_book", 30 ], | ||
| [ "carpentry_book", 24 ], | ||
| [ "scots_cookbook", 30 ], |
This comment has been minimized.
This comment has been minimized.
angoddu
Aug 7, 2017
Contributor
Why were these lines (3289-3312) changed? You should only change the lines that you have to for your PR
This comment has been minimized.
This comment has been minimized.
ituluwituluwzev
Aug 7, 2017
Author
Contributor
The part before the item list is changed by the web linter. I add 11 new items to the list, so I need larger numbers to keep the frequency. Then the entire list is changed.
This comment has been minimized.
This comment has been minimized.
angoddu
Aug 7, 2017
Contributor
Ooh my bad. I didn't notice the numbers changed for the other entries. That makes sense then. I would recommend that the "id" and "type" lines switch place to match the format of the other entries.
This comment has been minimized.
This comment has been minimized.
ituluwituluwzev
Aug 7, 2017
Author
Contributor
The web linter made the switch when I input the block. Probably other entries need changing, too.
kevingranade
merged commit 5b46435
into
CleverRaven:master
Sep 4, 2017
ituluwituluwzev
deleted the
ituluwituluwzev:martbook
branch
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ituluwituluwzev commentedAug 5, 2017
Books for Capoeira, Shaolin Adept, Venom Mob Protege, and Zui Quan spawn now. They spawn in the same group with The Book of Five Rings and The Modern Swordsman, both of which spawn at roughly 2% in the group. Now, Capoeira book spawns at the same rate, while the overall spawn-rate of other books is only roughly 2%, because these styles are all rare and mysterious.