Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rare martial art books spawn #21560

Merged
merged 1 commit into from Sep 4, 2017

Conversation

Projects
None yet
3 participants
@ituluwituluwzev
Copy link
Contributor

commented Aug 5, 2017

Books for Capoeira, Shaolin Adept, Venom Mob Protege, and Zui Quan spawn now. They spawn in the same group with The Book of Five Rings and The Modern Swordsman, both of which spawn at roughly 2% in the group. Now, Capoeira book spawns at the same rate, while the overall spawn-rate of other books is only roughly 2%, because these styles are all rare and mysterious.

[ "plays_book", 30 ],
[ "poetry_book", 30 ],
[ "carpentry_book", 24 ],
[ "scots_cookbook", 30 ],

This comment has been minimized.

Copy link
@angoddu

angoddu Aug 7, 2017

Contributor

Why were these lines (3289-3312) changed? You should only change the lines that you have to for your PR

This comment has been minimized.

Copy link
@ituluwituluwzev

ituluwituluwzev Aug 7, 2017

Author Contributor

The part before the item list is changed by the web linter. I add 11 new items to the list, so I need larger numbers to keep the frequency. Then the entire list is changed.

This comment has been minimized.

Copy link
@angoddu

angoddu Aug 7, 2017

Contributor

Ooh my bad. I didn't notice the numbers changed for the other entries. That makes sense then. I would recommend that the "id" and "type" lines switch place to match the format of the other entries.

This comment has been minimized.

Copy link
@ituluwituluwzev

ituluwituluwzev Aug 7, 2017

Author Contributor

The web linter made the switch when I input the block. Probably other entries need changing, too.

@kevingranade kevingranade merged commit 5b46435 into CleverRaven:master Sep 4, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.09%) to 22.678%
Details
gorgon-ghprb Build finished.
Details

@ituluwituluwzev ituluwituluwzev deleted the ituluwituluwzev:martbook branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.