Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSmarter animation delays + UI popups with a "hourglass" #21562
Conversation
codemime
added some commits
Jul 28, 2017
This comment has been minimized.
This comment has been minimized.
|
This is weird but: with these changes the box displayed on the active tile when examining isn't shown. I'm running this on a Mac – it's visible on master but not here. |
This comment has been minimized.
This comment has been minimized.
|
those delays are big hints that trouble is afoot nearby. perhaps an onscreen warning or something more noticeable than one line of text on the hud log? |
This comment has been minimized.
This comment has been minimized.
Delays shouldn't be happening for things that are not seen. A line in the log describing the skipped delay would be fine, but relying on delay to convey any information is inherently wrong. |
kevingranade
merged commit 83b067b
into
CleverRaven:master
Aug 13, 2017
codemime
deleted the
codemime:hangon_anim_popups
branch
Aug 13, 2017
kevingranade
added a commit
that referenced
this pull request
Feb 2, 2018
kevingranade
added a commit
that referenced
this pull request
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
codemime commentedAug 5, 2017
•
edited
Overview
Sometimes the game appears to be hanging for no apparent reason, but it, actually, isn't. The main reason of the "hangs" is invisible animation (if it's enabled, of course). It's invisible either to the player's alter ego or to the player themselves (because it's played beyond the screen bounds). Here are some frequent examples:
This PR mitigates (if not resolves) the issue.
Observable behavior
Implementation details
Nothing so exciting.