Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix NPC trade and item rewards #21584
Conversation
kevingranade
merged commit 96148bb
into
CleverRaven:master
Aug 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Coolthulhu commentedAug 9, 2017
Bug:
Asking NPC for an item reward for a mission can bug their
owedvalue.Exchange (trade with friends) requires it to be 0, otherwise it requires either explicit confirmation or refuses the trade.
Fixed both cause and symptom:
owesvalue