Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPC trade and item rewards #21584

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
2 participants
@Coolthulhu
Copy link
Contributor

commented Aug 9, 2017

Bug:
Asking NPC for an item reward for a mission can bug their owed value.
Exchange (trade with friends) requires it to be 0, otherwise it requires either explicit confirmation or refuses the trade.

Fixed both cause and symptom:

  • Trade with friends ignores owes value
  • It's no longer possible to ask for item rewards with friends. They give stuff for free, so it simply doesn't make sense for them to give it as a reward.

@kevingranade kevingranade merged commit 96148bb into CleverRaven:master Aug 13, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 22.868%
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.