New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative crafting options for welding goggles #21638

Merged
merged 16 commits into from Aug 23, 2017

Conversation

Projects
None yet
@Cosmitz
Contributor

Cosmitz commented Aug 15, 2017

Welding goggles are the cornerstone of starting to craft vehicles as well as a variety of parts, and often enough the entire progres is stalled by not having a pair of welding goggles, far past making an improvised welder at least. And then in turn, the welding goggles are stalled up by finding a single spray painter.

I reworked the crafting recipe to exclude the spray painter, but including half the charges of any of the paint cans (minus white), charcoal or coal, all which are more accessibily findable if you aim to look for them specifically.

Cosmitz added some commits Aug 15, 2017

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 15, 2017

Contributor

Why not allow spray cans as well as the other options?

Contributor

angoddu commented Aug 15, 2017

Why not allow spray cans as well as the other options?

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 15, 2017

Contributor

Because the spray can itself is a tool, not a consumable. Adding it as a part would 'consume it' and maybe you want something more to do with it later like a flamethrower. ~~

LE can't add it as a charge. Added as a single use item.

Contributor

Cosmitz commented Aug 15, 2017

Because the spray can itself is a tool, not a consumable. Adding it as a part would 'consume it' and maybe you want something more to do with it later like a flamethrower. ~~

LE can't add it as a charge. Added as a single use item.

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 15, 2017

Contributor

This is a spray can, filled with paint. Use this tool to make graffiti on the floor.

But it is a can of spray paint, not air. The charges in the can represent the amount of paint in the can

Contributor

angoddu commented Aug 15, 2017

This is a spray can, filled with paint. Use this tool to make graffiti on the floor.

But it is a can of spray paint, not air. The charges in the can represent the amount of paint in the can

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 15, 2017

Contributor

Yes a 5 charge consume would be great

Contributor

angoddu commented Aug 15, 2017

Yes a 5 charge consume would be great

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 15, 2017

Contributor

Nope can't add it as a charge, but added as a straight one unit use. That was probably the original reasoning for using it as a tool anyway.

Contributor

Cosmitz commented Aug 15, 2017

Nope can't add it as a charge, but added as a straight one unit use. That was probably the original reasoning for using it as a tool anyway.

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 15, 2017

Contributor

The one charge seems to be a bit unbalanced with the other options. I liked the idea of requiring 5 charges

Contributor

angoddu commented Aug 15, 2017

The one charge seems to be a bit unbalanced with the other options. I liked the idea of requiring 5 charges

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 15, 2017

Contributor

Sadly, not a possibility, but the option of using it is there. Technically it doesn't care how many charges you have in it, so you can even use a 1 charge spray can.

Contributor

Cosmitz commented Aug 15, 2017

Sadly, not a possibility, but the option of using it is there. Technically it doesn't care how many charges you have in it, so you can even use a 1 charge spray can.

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 15, 2017

Contributor

What about making a second recipe for the with paint/coal recipe and leave the existing one there with the tool charge set to 5 instead of 1

Contributor

angoddu commented Aug 15, 2017

What about making a second recipe for the with paint/coal recipe and leave the existing one there with the tool charge set to 5 instead of 1

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 15, 2017

Contributor

I'd imagine it's a bit frowned upon for creating additional recipies for the same item given i don't think we have a precedent. Also given the narrow use of spray cans anyway it's either using them for the goggles, using them for 'writing' on floors which i'm not even sure it works anymore, and for the flamethrower recipe, there isn't much competition.

Contributor

Cosmitz commented Aug 15, 2017

I'd imagine it's a bit frowned upon for creating additional recipies for the same item given i don't think we have a precedent. Also given the narrow use of spray cans anyway it's either using them for the goggles, using them for 'writing' on floors which i'm not even sure it works anymore, and for the flamethrower recipe, there isn't much competition.

@pisskop

This comment has been minimized.

Show comment
Hide comment
@pisskop

pisskop Aug 15, 2017

Contributor

using globs of paint to create a transparent eye protection apparatus seems more counter intuitive and maybe bright-nights-ey than an acceptable coregame recipe.

Contributor

pisskop commented Aug 15, 2017

using globs of paint to create a transparent eye protection apparatus seems more counter intuitive and maybe bright-nights-ey than an acceptable coregame recipe.

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 15, 2017

Contributor

Neither is layering paint on via a spraycan in order to create a shade 7.0 required for oxy torch cutting which then also provides IR protection somehow. But to counter that specific quirk on paints, you can thin them. In any case i feel it's a reasonable recipe aimed more at the context of the game as is, providing a gameplay solution to an existing bottleneck.

Contributor

Cosmitz commented Aug 15, 2017

Neither is layering paint on via a spraycan in order to create a shade 7.0 required for oxy torch cutting which then also provides IR protection somehow. But to counter that specific quirk on paints, you can thin them. In any case i feel it's a reasonable recipe aimed more at the context of the game as is, providing a gameplay solution to an existing bottleneck.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 15, 2017

Member

I'm not really a fan of the spraypaint recipe in the first place, I kind of suspect someone took this: http://www.doityourself.com/stry/how-to-build-your-own-welding-goggles and didn't actually read the directions to find out that the spraypaint is only used for making the rest of the goggles opaque, not for the lenses.

As for shitty improvised welding goggles, the only things I know of that would somewhat work are sunglass lenses, possibly several layers of them since you're frequently dealing with high intensity UV.

Can we maybe just have sunglasses spawn randomly and fairly frequently and make those satisfy the lens requirement? That sounds like something that could reasonably be common enough to meet your goal. Zombies can wear them, they can appear in convenience stores and at the front of a lot of shops, they can spawn in houses and cars.

If you can find some reasonable references to other DIY options, feel free (even if you can find something referencing the paint or spraint concept), but I'm not interested in making these recipes make even less sense than they do now.

Member

kevingranade commented Aug 15, 2017

I'm not really a fan of the spraypaint recipe in the first place, I kind of suspect someone took this: http://www.doityourself.com/stry/how-to-build-your-own-welding-goggles and didn't actually read the directions to find out that the spraypaint is only used for making the rest of the goggles opaque, not for the lenses.

As for shitty improvised welding goggles, the only things I know of that would somewhat work are sunglass lenses, possibly several layers of them since you're frequently dealing with high intensity UV.

Can we maybe just have sunglasses spawn randomly and fairly frequently and make those satisfy the lens requirement? That sounds like something that could reasonably be common enough to meet your goal. Zombies can wear them, they can appear in convenience stores and at the front of a lot of shops, they can spawn in houses and cars.

If you can find some reasonable references to other DIY options, feel free (even if you can find something referencing the paint or spraint concept), but I'm not interested in making these recipes make even less sense than they do now.

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 15, 2017

Contributor

@kevingranade Sunglasses are decently findable and we can increase their spawn a tiny bit, and i can also add another pair (or maybe two pairs?) of sunglasses in the second part of the recipe to satisfy the condition as an option to paint. The ideea has been tossed about and it's not a bad one(though there's more light than just UV coming out welding).

Either way, the final recipe would be something that could be crafted out of 2-3 pairs of sunglasses and some duct tape, if you don't have access to paint/charcoal.

IRL welding is based on a standard called 'shades' of how much light they allow in, with the darker tinted, the safer/better it is, but indeed, some types of welding only require a lower shade rating. Did a new commit to include them.

Contributor

Cosmitz commented Aug 15, 2017

@kevingranade Sunglasses are decently findable and we can increase their spawn a tiny bit, and i can also add another pair (or maybe two pairs?) of sunglasses in the second part of the recipe to satisfy the condition as an option to paint. The ideea has been tossed about and it's not a bad one(though there's more light than just UV coming out welding).

Either way, the final recipe would be something that could be crafted out of 2-3 pairs of sunglasses and some duct tape, if you don't have access to paint/charcoal.

IRL welding is based on a standard called 'shades' of how much light they allow in, with the darker tinted, the safer/better it is, but indeed, some types of welding only require a lower shade rating. Did a new commit to include them.

@Coolthulhu

This comment has been minimized.

Show comment
Hide comment
@Coolthulhu

Coolthulhu Aug 16, 2017

Contributor

I don't see anyone objecting to the change to gameplay, but there is a minor technical problem:
You forgot one space, meaning the recipe is not in correct format (it has to be exactly identical to what would linter produce).
To ensure your files are always in correct format, run them through this:
http://dev.narc.ro/cataclysm/format.html

EDIT: You can see the problems below. Linter problems are only reported by the "gorgon". If you see a check failing, check in details what is causing it. In case of gorgon, you want to go details->console output and scroll down to the bottom (that's usually where the errors are).

Contributor

Coolthulhu commented Aug 16, 2017

I don't see anyone objecting to the change to gameplay, but there is a minor technical problem:
You forgot one space, meaning the recipe is not in correct format (it has to be exactly identical to what would linter produce).
To ensure your files are always in correct format, run them through this:
http://dev.narc.ro/cataclysm/format.html

EDIT: You can see the problems below. Linter problems are only reported by the "gorgon". If you see a check failing, check in details what is causing it. In case of gorgon, you want to go details->console output and scroll down to the bottom (that's usually where the errors are).

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 16, 2017

Contributor

I could have sworn i did. Shrug. Fixed. Thanks for the in-depth explanation.

Contributor

Cosmitz commented Aug 16, 2017

I could have sworn i did. Shrug. Fixed. Thanks for the in-depth explanation.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 16, 2017

Member

I wasn't suggesting sunglasses as an alternative to the paint, I was suggesting it as the ONLY option (unless someone knows of something else that will actually work).

Member

kevingranade commented Aug 16, 2017

I wasn't suggesting sunglasses as an alternative to the paint, I was suggesting it as the ONLY option (unless someone knows of something else that will actually work).

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 16, 2017

Contributor

While on this topic, can stylish sunglasses be allowed in the recipe? Seems odd that they aren't there currently

Contributor

angoddu commented Aug 16, 2017

While on this topic, can stylish sunglasses be allowed in the recipe? Seems odd that they aren't there currently

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 17, 2017

Contributor

@kevingranade

I'm one to choose gameplay over ultrarealism, since if we're going full real, there can be no custom-crafted welding goggles. Welding goggles/shields all come with filters that filter out 100% of UV and IR light and you can't just do that by stacking on comercial grade sunglasses or any kind of paint. The addition of the shade rating is literally how much of the visible light spectrum they dim as so the welder can work in confort as well as reduce the maximum amount of brightness that their eyes are subjected to.

Not even IRL do you instantly, massively, and permanently damage your vision by welding unprotected. It stings and it's not healthy long term, especially if you're doing oxy, but for stick welding, which is what the basic 'welding' everyone thinks off i imagine, it won't kill you.

But for pure, raw, gameplay considerations given what we have in the game and the certain level of 'makes sense' we allow in it, using paint to dim welding goggles or stacking three pairs of sunglasses is fine enough. Plus, the core issue is that they really are a rather silly but poignant bottleneck in progression.

I also have added stylish sunglasses to the recipe.

PS: Also ridiculous that welding goggles are needed to craft nightvision goggles but that's an entire other matter.

Contributor

Cosmitz commented Aug 17, 2017

@kevingranade

I'm one to choose gameplay over ultrarealism, since if we're going full real, there can be no custom-crafted welding goggles. Welding goggles/shields all come with filters that filter out 100% of UV and IR light and you can't just do that by stacking on comercial grade sunglasses or any kind of paint. The addition of the shade rating is literally how much of the visible light spectrum they dim as so the welder can work in confort as well as reduce the maximum amount of brightness that their eyes are subjected to.

Not even IRL do you instantly, massively, and permanently damage your vision by welding unprotected. It stings and it's not healthy long term, especially if you're doing oxy, but for stick welding, which is what the basic 'welding' everyone thinks off i imagine, it won't kill you.

But for pure, raw, gameplay considerations given what we have in the game and the certain level of 'makes sense' we allow in it, using paint to dim welding goggles or stacking three pairs of sunglasses is fine enough. Plus, the core issue is that they really are a rather silly but poignant bottleneck in progression.

I also have added stylish sunglasses to the recipe.

PS: Also ridiculous that welding goggles are needed to craft nightvision goggles but that's an entire other matter.

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 17, 2017

Contributor

I also have added stylish sunglasses to the recipe.

Thank you

Contributor

angoddu commented Aug 17, 2017

I also have added stylish sunglasses to the recipe.

Thank you

@pisskop

This comment has been minimized.

Show comment
Hide comment
@pisskop

pisskop Aug 17, 2017

Contributor

I demand stylish welding googles nao :b

Contributor

pisskop commented Aug 17, 2017

I demand stylish welding googles nao :b

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 17, 2017

Member

I'm one to choose gameplay over ultrarealism,

This isn't ultrarealism, this is discarding a nonsense crafting option now that we have a better alternative. There are easy to find sources (including the one I linked above) indicating that people use sunglasses when welding (yes I'm sure it's a terrible idea, but at some point you accept "close enough"), but im not aware of any such indication that people spray or dip lenses in paint for this purpose.

Plus, the core issue is that they really are a rather silly but poignant bottleneck in progression.

Does replacing spray paint with sunglasses fix the bottleneck or not? "Dip lenses in paint" and whatever is supposed to happen with charcoal aren't options, so we're just comparing spray paint and sunglass lenses here.

Member

kevingranade commented Aug 17, 2017

I'm one to choose gameplay over ultrarealism,

This isn't ultrarealism, this is discarding a nonsense crafting option now that we have a better alternative. There are easy to find sources (including the one I linked above) indicating that people use sunglasses when welding (yes I'm sure it's a terrible idea, but at some point you accept "close enough"), but im not aware of any such indication that people spray or dip lenses in paint for this purpose.

Plus, the core issue is that they really are a rather silly but poignant bottleneck in progression.

Does replacing spray paint with sunglasses fix the bottleneck or not? "Dip lenses in paint" and whatever is supposed to happen with charcoal aren't options, so we're just comparing spray paint and sunglass lenses here.

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 17, 2017

Contributor

They fix the bottleneck due to a greater availibility of crafting requirements alongside the other varied options which all fall into the 'makes sense in CDDA' category. It works as a gameplay solution for the game as-is without re-examining why the item exists to be crafted in the first place and why in that way.

Since if we were to do that:

Spray paint does nothing, it's just aersolised thinner paint, same as layering a thinner coat of existing paint and charcoal/coal can be ground up and made a paste which would fare just as well. In short, you can't make proper modern welding goggles without proper anti UV/IR solutions. If this was the original idea for 'spraypaint' goggles, they missed out the part where you have to apply the shade 5 UV tint, which is literally a film of UV blocking transparent material, the same that can be used for cars and something very specific that we wouldn't add to CDDA just for the sake of crafting one item (no, even the filters in current-day monitors aren't suited). Sunglasses, even 'professional' 3M sunglasses that say they block '99.9%' of UV light only reffer to the UV light emitted by the sun, which is by far not in the same league as what happens when you're oxy-torch welding steel plates together.

As for ultrarealism: I have stick welded before with no protection. Eyes gone red and i started tearing up after a short welding session while working over at my granparent's house on their balcony. Pleasent? Nope. Life threathening? Nope. Smart? Eehh. Doable? Totally.

So yes, it would be neat to create an underlying system that dealt with arc-eye due to welding unprotected, with conditional debuffs all through CDDA's fantastic trait/disease system, and varied qualities of welding glasses and solutions which can be found which would be scaled to the type of welding instrument you are using, stick/jet/plasma/oxy, as they are not the same in regards to the dangers they pose. And while we're here, having to wear full body clothing instead of welding in boxer shorts could also be implemented as welders may often end up 'sunburnt' by welding with exposed skin.

Maybe i or someone else may be inclined in the future to go deeper into welding, as vehicle construction is a core part of CDDA, working to bring the mechanic to the proeminent front which it deserves and allowing more granularity and the option to create gameplay upon the system.

But for this exact moment in time and space, i think this is just a proper fix in the right direction for the CDDA in the state of the game as it is now, and which will not impede any further plans regarding welding.

Contributor

Cosmitz commented Aug 17, 2017

They fix the bottleneck due to a greater availibility of crafting requirements alongside the other varied options which all fall into the 'makes sense in CDDA' category. It works as a gameplay solution for the game as-is without re-examining why the item exists to be crafted in the first place and why in that way.

Since if we were to do that:

Spray paint does nothing, it's just aersolised thinner paint, same as layering a thinner coat of existing paint and charcoal/coal can be ground up and made a paste which would fare just as well. In short, you can't make proper modern welding goggles without proper anti UV/IR solutions. If this was the original idea for 'spraypaint' goggles, they missed out the part where you have to apply the shade 5 UV tint, which is literally a film of UV blocking transparent material, the same that can be used for cars and something very specific that we wouldn't add to CDDA just for the sake of crafting one item (no, even the filters in current-day monitors aren't suited). Sunglasses, even 'professional' 3M sunglasses that say they block '99.9%' of UV light only reffer to the UV light emitted by the sun, which is by far not in the same league as what happens when you're oxy-torch welding steel plates together.

As for ultrarealism: I have stick welded before with no protection. Eyes gone red and i started tearing up after a short welding session while working over at my granparent's house on their balcony. Pleasent? Nope. Life threathening? Nope. Smart? Eehh. Doable? Totally.

So yes, it would be neat to create an underlying system that dealt with arc-eye due to welding unprotected, with conditional debuffs all through CDDA's fantastic trait/disease system, and varied qualities of welding glasses and solutions which can be found which would be scaled to the type of welding instrument you are using, stick/jet/plasma/oxy, as they are not the same in regards to the dangers they pose. And while we're here, having to wear full body clothing instead of welding in boxer shorts could also be implemented as welders may often end up 'sunburnt' by welding with exposed skin.

Maybe i or someone else may be inclined in the future to go deeper into welding, as vehicle construction is a core part of CDDA, working to bring the mechanic to the proeminent front which it deserves and allowing more granularity and the option to create gameplay upon the system.

But for this exact moment in time and space, i think this is just a proper fix in the right direction for the CDDA in the state of the game as it is now, and which will not impede any further plans regarding welding.

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 17, 2017

Contributor

From what I can tell @Cosmitz wants to allow the use of paint cans in the recipe to make it easier to craft welding goggles without needing to find a spray can. The issue that @kevingranade brings up is that instead of making an unrealistic crafting recipe more unrealistic to change it to be something more realistic by using sunglasses while still increasing the availability of the crafting components, since sunglasses are more common that spray cans anyway. @Cosmitz also proposed to increase the spawn rate of sunglasses to make it even easier to gather enough components for this recipe.

Instead of debating the higher level reasoning as to why/when the change should be made, we should simply address the issue that opened this PR, welding goggles being too hard to craft early game. If we make the recipe only require the base glasses and 2 sunglasses, while also increasing the spawn rate of sunglasses, should be a good compromise on both sides right? Welding goggles are easier to craft and are more realistic.

I know I'm still new here so I may be missing something, but this seems like a lot of debate over fixing the simple issue of needing welding goggles easier to get. Hope this helps :)

Contributor

angoddu commented Aug 17, 2017

From what I can tell @Cosmitz wants to allow the use of paint cans in the recipe to make it easier to craft welding goggles without needing to find a spray can. The issue that @kevingranade brings up is that instead of making an unrealistic crafting recipe more unrealistic to change it to be something more realistic by using sunglasses while still increasing the availability of the crafting components, since sunglasses are more common that spray cans anyway. @Cosmitz also proposed to increase the spawn rate of sunglasses to make it even easier to gather enough components for this recipe.

Instead of debating the higher level reasoning as to why/when the change should be made, we should simply address the issue that opened this PR, welding goggles being too hard to craft early game. If we make the recipe only require the base glasses and 2 sunglasses, while also increasing the spawn rate of sunglasses, should be a good compromise on both sides right? Welding goggles are easier to craft and are more realistic.

I know I'm still new here so I may be missing something, but this seems like a lot of debate over fixing the simple issue of needing welding goggles easier to get. Hope this helps :)

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 17, 2017

Contributor

I think @kevingranade means that if we are going to touch this, we should rework it to be entirely more 'down to earth' than what it is currently, and thought the 'stacking of sunglasses' to be an option to do that, which i mentioned that it really isn't. I countered with the fact that a proper grounding of this feature is a larger body of work waiting to happen, not bound to just fixing one recipe, and for this exact moment, the issue this PR yields to fix would be fixed by it under the current status of the game and its current internal logic.

Contributor

Cosmitz commented Aug 17, 2017

I think @kevingranade means that if we are going to touch this, we should rework it to be entirely more 'down to earth' than what it is currently, and thought the 'stacking of sunglasses' to be an option to do that, which i mentioned that it really isn't. I countered with the fact that a proper grounding of this feature is a larger body of work waiting to happen, not bound to just fixing one recipe, and for this exact moment, the issue this PR yields to fix would be fixed by it under the current status of the game and its current internal logic.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 21, 2017

Member

This went totally off the rails:

  1. Restore the sunglasses as a welding mask option.
  2. Eclipse glasses don't rate more than a "1" entry in any of the places you have them spawning, and they shouldn't spawn in the possession of any monsters or NPCs. The current settings have them being unbelievably common, jarringly so.
  3. There shouldn't be non-meaningful changes, you ended up shifting around formatting when you added and then removed things in several places.
Member

kevingranade commented Aug 21, 2017

This went totally off the rails:

  1. Restore the sunglasses as a welding mask option.
  2. Eclipse glasses don't rate more than a "1" entry in any of the places you have them spawning, and they shouldn't spawn in the possession of any monsters or NPCs. The current settings have them being unbelievably common, jarringly so.
  3. There shouldn't be non-meaningful changes, you ended up shifting around formatting when you added and then removed things in several places.
@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 21, 2017

Contributor
  1. If we're following the realism angle, sunglasses don't make a lick of sense, no more than painting, so i don't see a reason to include them.

  2. Will remove them from monsters or NPCs and then only be present only in static locations. I'll decrease them even further if your experience tells you that these will be too common, however, i will note that the whole point of the PR was for welding goggles to be /easier/ to craft, not harder.

  3. I'll rework the stylised document to correspond to the original but after working for a bit in different jsons over the last week, i noticed a distinct lack of congruent style between them and even a lack of stylisation between sections in the same json. Either way, agreed, not the PR to start changing that.

Contributor

Cosmitz commented Aug 21, 2017

  1. If we're following the realism angle, sunglasses don't make a lick of sense, no more than painting, so i don't see a reason to include them.

  2. Will remove them from monsters or NPCs and then only be present only in static locations. I'll decrease them even further if your experience tells you that these will be too common, however, i will note that the whole point of the PR was for welding goggles to be /easier/ to craft, not harder.

  3. I'll rework the stylised document to correspond to the original but after working for a bit in different jsons over the last week, i noticed a distinct lack of congruent style between them and even a lack of stylisation between sections in the same json. Either way, agreed, not the PR to start changing that.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 21, 2017

Member
  1. Crafting welding goggles with sunglass lenses is still the least-bad compromise we have. Regardless of how common eclipse glasses are at some specific point in time, they arent generally common, and worse theyre extremely obscure.
  2. That's why I said to keep sunglasses in the recipe.
Member

kevingranade commented Aug 21, 2017

  1. Crafting welding goggles with sunglass lenses is still the least-bad compromise we have. Regardless of how common eclipse glasses are at some specific point in time, they arent generally common, and worse theyre extremely obscure.
  2. That's why I said to keep sunglasses in the recipe.
@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 21, 2017

Contributor

Readded the variety of sunglasses as optional craftables in the recipe.

Contributor

Cosmitz commented Aug 21, 2017

Readded the variety of sunglasses as optional craftables in the recipe.

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 21, 2017

Contributor

Why was the duct tape/medical tape amounts doubled?

Contributor

angoddu commented Aug 21, 2017

Why was the duct tape/medical tape amounts doubled?

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 21, 2017

Contributor

To offset the fewer diversity overall of requirements needed. Plus it's still within how much you can find on a single pick-up.

Contributor

Cosmitz commented Aug 21, 2017

To offset the fewer diversity overall of requirements needed. Plus it's still within how much you can find on a single pick-up.

@Cyrano7

This comment has been minimized.

Show comment
Hide comment
@Cyrano7

Cyrano7 Aug 21, 2017

Member

Its looks like the only purpose and the only future purpose of the eclipse glasses is to craft the welding goggles. So as soon as you have a pair of welding goggles they are just clutter. I don't think having another such narrowly used item is good. Might be just better to keep the recipe with the sunglasses for now until some other form of advanced crafting comes about.

Member

Cyrano7 commented Aug 21, 2017

Its looks like the only purpose and the only future purpose of the eclipse glasses is to craft the welding goggles. So as soon as you have a pair of welding goggles they are just clutter. I don't think having another such narrowly used item is good. Might be just better to keep the recipe with the sunglasses for now until some other form of advanced crafting comes about.

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 21, 2017

Contributor

I tried to make them more than just clutter. They also give blindness in normal light so that makes for a cheap blindfold alternative, as well as having Glare Reduction 3 for whatever else it may be used as a quality in the game. It's also good as a future crafting item since it features lenses/materials which would realistically be useful in other recipes, and are highly specialized.

In any case, the only reason i added said eclipse glasses was because it was stated that we needed a more realistic option if we were going to touch the recipe. This is it. We then re-added normal sunglasses as a compromise to overcome a predisposition of not wanting to spawn more of said eclipse glasses. That's where we are now.

Again, the raw purpose of this PR was to make the welding goggles more easily craftable. My initial option (paint/charcoal/coal) was as fine a solution as just allowing sunglasses, from a realism point of view, and fulfilled the gameplay criterias. The ultrarealistic+semi-relistic option in the current latest PR is again, completely fine for allowing what we wanted initially. If we remove the eclipse glasses, we may need to go and tweak sunglasses drop rates a bit, but in the end, this would be the third or forth refactoring of this PR.

Contributor

Cosmitz commented Aug 21, 2017

I tried to make them more than just clutter. They also give blindness in normal light so that makes for a cheap blindfold alternative, as well as having Glare Reduction 3 for whatever else it may be used as a quality in the game. It's also good as a future crafting item since it features lenses/materials which would realistically be useful in other recipes, and are highly specialized.

In any case, the only reason i added said eclipse glasses was because it was stated that we needed a more realistic option if we were going to touch the recipe. This is it. We then re-added normal sunglasses as a compromise to overcome a predisposition of not wanting to spawn more of said eclipse glasses. That's where we are now.

Again, the raw purpose of this PR was to make the welding goggles more easily craftable. My initial option (paint/charcoal/coal) was as fine a solution as just allowing sunglasses, from a realism point of view, and fulfilled the gameplay criterias. The ultrarealistic+semi-relistic option in the current latest PR is again, completely fine for allowing what we wanted initially. If we remove the eclipse glasses, we may need to go and tweak sunglasses drop rates a bit, but in the end, this would be the third or forth refactoring of this PR.

@Cyrano7

This comment has been minimized.

Show comment
Hide comment
@Cyrano7

Cyrano7 Aug 21, 2017

Member

@Cosmitz Making them completely blind you is not good ether. Eclipse glasses don't block out all light like a blindfold. The highest glare protection level on a item in the game right now is 2, so having 3 is pointless. As for materials/lenses, almost all eclipse glasses you see are the disposable kind so i'm not sure how useful those would be.

It might be better to just change the recipe to take sunglasses instead for now. Finding 3 pairs of sunglasses is easier then finding the spray can i'm pretty sure. If you think the welding goggles are still to hard to craft/find you can always bump the spawns for the glasses or goggles later.

Member

Cyrano7 commented Aug 21, 2017

@Cosmitz Making them completely blind you is not good ether. Eclipse glasses don't block out all light like a blindfold. The highest glare protection level on a item in the game right now is 2, so having 3 is pointless. As for materials/lenses, almost all eclipse glasses you see are the disposable kind so i'm not sure how useful those would be.

It might be better to just change the recipe to take sunglasses instead for now. Finding 3 pairs of sunglasses is easier then finding the spray can i'm pretty sure. If you think the welding goggles are still to hard to craft/find you can always bump the spawns for the glasses or goggles later.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 21, 2017

Member

I don't think having another such narrowly used item is good.

Project norm is to be inclusive of obscure items, but keep an eye on how common they are. Also as @Cosmitz points out, they're potentially quite useful in other areas as a crafting material.

The blindness thing is pretty iffy, they're quite bad at covering your entire field of view. That's minor enough that I'd just patch it out in a merge or just leave it for correction later though, considering that this IS a very nice set of changes that is in high demand.

The highest glare protection level on a item in the game right now is 2, so having 3 is pointless.

~ Build it and they will come ~

As for materials/lenses, almost all eclipse glasses you see are the disposable kind so i'm not sure how useful those would be.

Mine are quite fragile, surprisingly so. This further convinces me that they aren't going to be at all common a month or so after the most recent eclipse, but I think their fragility can be overlooked, if it's really bothering you I'd happily accept a recipe that adds additional lenses to protect the filters.

I think the sunglasses change is the significant one and the eclipse glasses are adding flavor, but that's fine.

Member

kevingranade commented Aug 21, 2017

I don't think having another such narrowly used item is good.

Project norm is to be inclusive of obscure items, but keep an eye on how common they are. Also as @Cosmitz points out, they're potentially quite useful in other areas as a crafting material.

The blindness thing is pretty iffy, they're quite bad at covering your entire field of view. That's minor enough that I'd just patch it out in a merge or just leave it for correction later though, considering that this IS a very nice set of changes that is in high demand.

The highest glare protection level on a item in the game right now is 2, so having 3 is pointless.

~ Build it and they will come ~

As for materials/lenses, almost all eclipse glasses you see are the disposable kind so i'm not sure how useful those would be.

Mine are quite fragile, surprisingly so. This further convinces me that they aren't going to be at all common a month or so after the most recent eclipse, but I think their fragility can be overlooked, if it's really bothering you I'd happily accept a recipe that adds additional lenses to protect the filters.

I think the sunglasses change is the significant one and the eclipse glasses are adding flavor, but that's fine.

@Cyrano7

This comment has been minimized.

Show comment
Hide comment
@Cyrano7

Cyrano7 Aug 22, 2017

Member

@kevingranade Build it and they will come? That's kinda putting the cart before the horse huh? Nothing requires glare protection 3 as of yet. Not that that can't change in the future but its not here yet so better to put 2.

Member

Cyrano7 commented Aug 22, 2017

@kevingranade Build it and they will come? That's kinda putting the cart before the horse huh? Nothing requires glare protection 3 as of yet. Not that that can't change in the future but its not here yet so better to put 2.

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 22, 2017

Contributor

It's not hurting or messing up anything right now by adding it. Is it really a point of contention? I just thought it would be neat even if only for the flavor of it. Tool qualities are all over the place right now with no real use of the gradient of them anyway, oftentimes it's SCREW : 1 and that's it.

I have no issue dropping it to 2 since that's not what this PR is aiming to push as a change, but 'don't put it in since we don't need it', is not something that should apply to the open-source project of CDDA where in just yesterday i found an anthropomorphic dinosaur suit that someone added at some point. Did we need a dinosaur suit? Of course not. Is it neat? Yes it is.

Contributor

Cosmitz commented Aug 22, 2017

It's not hurting or messing up anything right now by adding it. Is it really a point of contention? I just thought it would be neat even if only for the flavor of it. Tool qualities are all over the place right now with no real use of the gradient of them anyway, oftentimes it's SCREW : 1 and that's it.

I have no issue dropping it to 2 since that's not what this PR is aiming to push as a change, but 'don't put it in since we don't need it', is not something that should apply to the open-source project of CDDA where in just yesterday i found an anthropomorphic dinosaur suit that someone added at some point. Did we need a dinosaur suit? Of course not. Is it neat? Yes it is.

@BorkBorkGoesTheCode

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 22, 2017

Contributor

Mylar is pretty cool but sadly atm inexistent in CDDA, and we'd need to really entrench it as a crafting material otherwise it'd be an edge-case. Plus for exactly this use, it still needs to be aluminized/coated with a film of aluminum; making welding gogles out of an emergency blanket and aluminum powder kind of goes agains the point of making them more accessible. :)

Contributor

Cosmitz commented Aug 22, 2017

Mylar is pretty cool but sadly atm inexistent in CDDA, and we'd need to really entrench it as a crafting material otherwise it'd be an edge-case. Plus for exactly this use, it still needs to be aluminized/coated with a film of aluminum; making welding gogles out of an emergency blanket and aluminum powder kind of goes agains the point of making them more accessible. :)

@angoddu

This comment has been minimized.

Show comment
Hide comment
@angoddu

angoddu Aug 22, 2017

Contributor

I say we accept this PR as is (potentially without blindness) and open an issue to discuss making a more realistic welding system. That way this PR doesn't get even more crowded than it already is

i found an anthropomorphic dinosaur suit

P.S. I love using those in the winter as pajamas. Keeps me warm and makes me laugh

Contributor

angoddu commented Aug 22, 2017

I say we accept this PR as is (potentially without blindness) and open an issue to discuss making a more realistic welding system. That way this PR doesn't get even more crowded than it already is

i found an anthropomorphic dinosaur suit

P.S. I love using those in the winter as pajamas. Keeps me warm and makes me laugh

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Aug 22, 2017

Member

Mylar is pretty cool but sadly atm inexistent in CDDA, and we'd need to really entrench it as a crafting material otherwise it'd be an edge-case. Plus for exactly this use, it still needs to be aluminized/coated with a film of aluminum; making welding gogles out of an emergency blanket and aluminum powder kind of goes agains the point of making them more accessible. :)

We do have aluminized mylar in CDDA in form of emergency blanket despite its material is stated as plastic. https://en.wikipedia.org/wiki/Space_blanket
Maybe we can salvage something from here?

EDIT: sorry, didn't read your post thoroughly, so I'm basically repeating what you've said.

Member

Night-Pryanik commented Aug 22, 2017

Mylar is pretty cool but sadly atm inexistent in CDDA, and we'd need to really entrench it as a crafting material otherwise it'd be an edge-case. Plus for exactly this use, it still needs to be aluminized/coated with a film of aluminum; making welding gogles out of an emergency blanket and aluminum powder kind of goes agains the point of making them more accessible. :)

We do have aluminized mylar in CDDA in form of emergency blanket despite its material is stated as plastic. https://en.wikipedia.org/wiki/Space_blanket
Maybe we can salvage something from here?

EDIT: sorry, didn't read your post thoroughly, so I'm basically repeating what you've said.

@Cosmitz

This comment has been minimized.

Show comment
Hide comment
@Cosmitz

Cosmitz Aug 22, 2017

Contributor

I could add it as a component instead of the glasses for what it's worth, however i feel it may be somewhat of an obtuse requirement for the general player to conceptualise.

EIther way, if @kevingranade 's fine with it, i'll add it in. It does go towards the goal of this PR.

Contributor

Cosmitz commented Aug 22, 2017

I could add it as a component instead of the glasses for what it's worth, however i feel it may be somewhat of an obtuse requirement for the general player to conceptualise.

EIther way, if @kevingranade 's fine with it, i'll add it in. It does go towards the goal of this PR.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Aug 23, 2017

Member

Let's just call this one now, though there are a few tweaks I'm going to submit as my own PR.

Member

kevingranade commented Aug 23, 2017

Let's just call this one now, though there are a few tweaks I'm going to submit as my own PR.

@kevingranade kevingranade merged commit dd684e2 into CleverRaven:master Aug 23, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-1.004%) to 21.937%
Details
gorgon-ghprb Build finished.
Details
@Cyrano7

This comment has been minimized.

Show comment
Hide comment
@Cyrano7

Cyrano7 Aug 23, 2017

Member

@Cosmitz Coming back to the party late it seems. Yes we actually needed the dino suit in the game. This has nothing to do with whether we need just for fun content. Its just making sure everything is worked out before merge. Sure irl you could find a pair of eclipse glasses. Is it neat? No it is not.

Member

Cyrano7 commented Aug 23, 2017

@Cosmitz Coming back to the party late it seems. Yes we actually needed the dino suit in the game. This has nothing to do with whether we need just for fun content. Its just making sure everything is worked out before merge. Sure irl you could find a pair of eclipse glasses. Is it neat? No it is not.

@tinukedaya

This comment has been minimized.

Show comment
Hide comment
@tinukedaya

tinukedaya Aug 25, 2017

Coming in late on this, I'm sorry for that, but the question I have is:
Why would I EVER want to build welding goggles using the eclipse glasses once I find those? Seeing as they have the Glare Protection 3, they are more that suited for welding in game, without any other hassle like getting proper skills, book or other components...

tinukedaya commented Aug 25, 2017

Coming in late on this, I'm sorry for that, but the question I have is:
Why would I EVER want to build welding goggles using the eclipse glasses once I find those? Seeing as they have the Glare Protection 3, they are more that suited for welding in game, without any other hassle like getting proper skills, book or other components...

@Treah

This comment has been minimized.

Show comment
Hide comment
@Treah

Treah Oct 16, 2017

Contributor

I hate this change so much :(. Somone said that sunglasses are easy to find... Yeah 22 days of searching and not a single one.... not easy to find if your on a low spawn number. This stalls crafting greatly as finding spray cans is oddly WAY simpler.. Most people never craft them from sunglasses and just look for PBA masks. I feel this needs a rework to not make using the makeshift welder stall for SO SO long.

Contributor

Treah commented Oct 16, 2017

I hate this change so much :(. Somone said that sunglasses are easy to find... Yeah 22 days of searching and not a single one.... not easy to find if your on a low spawn number. This stalls crafting greatly as finding spray cans is oddly WAY simpler.. Most people never craft them from sunglasses and just look for PBA masks. I feel this needs a rework to not make using the makeshift welder stall for SO SO long.

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Oct 16, 2017

Member

There are tons of sunglasses dropping from the zeds.

Member

Night-Pryanik commented Oct 16, 2017

There are tons of sunglasses dropping from the zeds.

@Treah

This comment has been minimized.

Show comment
Hide comment
@Treah

Treah Oct 16, 2017

Contributor

Yeah not from what I see... This would have been a lot better if you could disassemble the glasses into dark lenses that you then could use to craft them. As it stands you have to find 3 of the exact same kind. Even with normal spawn people still complain about this...

Contributor

Treah commented Oct 16, 2017

Yeah not from what I see... This would have been a lot better if you could disassemble the glasses into dark lenses that you then could use to craft them. As it stands you have to find 3 of the exact same kind. Even with normal spawn people still complain about this...

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Oct 16, 2017

Member

@Treah created a PR (#22160) based on your proposal.

Member

Night-Pryanik commented Oct 16, 2017

@Treah created a PR (#22160) based on your proposal.

@Cosmitz Cosmitz deleted the Cosmitz:alternative-crafting-components-for-welding-goggles branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment