Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Moved bank mapgen to json #21823

Merged
merged 3 commits into from Sep 10, 2017

Conversation

5 participants
@ZhilkinSerg
Copy link
Contributor

commented Sep 9, 2017

No description provided.

@John-Candlebury

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2017

The old spawn system allowed for more than a single item to spawn on each safe. I think it would be a good idea to let that happen in here, after all the items inside vaults are some of the rarest in game

m->furn_set(21, 2, f_indoor_plant);
}
//Windows or glass wall front?
int tmp = 0;

This comment has been minimized.

Copy link
@BorkBorkGoesTheCode

BorkBorkGoesTheCode Sep 9, 2017

Contributor

Is there any way to retain the old random terrain generation?

This comment has been minimized.

Copy link
@Coolthulhu

Coolthulhu Sep 9, 2017

Contributor

Multiple definitions - one per variant.

This comment has been minimized.

Copy link
@ZhilkinSerg

ZhilkinSerg Sep 9, 2017

Author Contributor

Indoor plants are random - they can be spawned with 50% probability. I've also restored random locked doors just now.

Other randomness is not easily possible now in JSON (if even possible at all). Distinct random tiles have distinct random generator, so I cannot make exact same random terrain/furniture for two different tiles in JSON. It is only possible in LUA, but using it is not a very good idea.

I can make several variants of bank building: with and without glass front walls, etc.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2017

The old spawn system allowed for more than a single item to spawn on each safe. I think it would be a good idea to let that happen in here, after all the items inside vaults are some of the rarest in game

Wasn't old loot system broken?

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2017

Wasn't old loot system broken?

I think it was the usage that was broken, not the old system in general.

And yes, more than 1 item in a safe, please.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2017

Increased quantity of items in safes.

@Coolthulhu Coolthulhu self-assigned this Sep 10, 2017

@Coolthulhu Coolthulhu merged commit 30b4a96 into CleverRaven:master Sep 10, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 21.985%
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg deleted the ZhilkinSerg:mapgen-bank branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.