Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[RDY] Moved bank mapgen to json #21823
Conversation
ZhilkinSerg
referenced this pull request
Sep 9, 2017
Closed
List of hard-coded mapgen functions to be moved to JSON #21824
This comment has been minimized.
This comment has been minimized.
|
The old spawn system allowed for more than a single item to spawn on each safe. I think it would be a good idea to let that happen in here, after all the items inside vaults are some of the rarest in game |
BorkBorkGoesTheCode
reviewed
Sep 9, 2017
| m->furn_set(21, 2, f_indoor_plant); | ||
| } | ||
| //Windows or glass wall front? | ||
| int tmp = 0; |
This comment has been minimized.
This comment has been minimized.
BorkBorkGoesTheCode
Sep 9, 2017
Contributor
Is there any way to retain the old random terrain generation?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ZhilkinSerg
Sep 9, 2017
•
Author
Contributor
Indoor plants are random - they can be spawned with 50% probability. I've also restored random locked doors just now.
Other randomness is not easily possible now in JSON (if even possible at all). Distinct random tiles have distinct random generator, so I cannot make exact same random terrain/furniture for two different tiles in JSON. It is only possible in LUA, but using it is not a very good idea.
I can make several variants of bank building: with and without glass front walls, etc.
This comment has been minimized.
This comment has been minimized.
Wasn't old loot system broken? |
This comment has been minimized.
This comment has been minimized.
I think it was the usage that was broken, not the old system in general. And yes, more than 1 item in a safe, please. |
This comment has been minimized.
This comment has been minimized.
|
Increased quantity of items in safes. |
ZhilkinSerg commentedSep 9, 2017
No description provided.