Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMoved `radio_tower` mapgen to JSON #21834
Conversation
ZhilkinSerg
referenced this pull request
Sep 10, 2017
Closed
List of hard-coded mapgen functions to be moved to JSON #21824
Coolthulhu
self-assigned this
Sep 10, 2017
Coolthulhu
merged commit caab589
into
CleverRaven:master
Sep 10, 2017
ZhilkinSerg
deleted the
ZhilkinSerg:mapgen-radio-tower
branch
Sep 11, 2017
ZhilkinSerg
referenced this pull request
Sep 14, 2017
Closed
Radio tower hardcoded function not removed correctly #21880
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ZhilkinSerg Github automatically links issues (in both directions) when they get mentioned as |
This comment has been minimized.
This comment has been minimized.
Thanks, didn't know that. |
ZhilkinSerg
added this to Done
in Mapgen and overmapgen improvements
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedSep 10, 2017
Some randomness (starter point of tower and building mapgen, door and windows location) was dropped.