Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMoved `sub_station` mapgen to JSON #21836
Conversation
ZhilkinSerg
referenced this pull request
Sep 10, 2017
Closed
List of hard-coded mapgen functions to be moved to JSON #21824
Coolthulhu
self-assigned this
Sep 10, 2017
Coolthulhu
merged commit 6816de7
into
CleverRaven:master
Sep 10, 2017
This comment has been minimized.
This comment has been minimized.
|
Were vending machines with food nerfed recently? I'm only getting 1 food item per machine and the code here didn't change that. |
This comment has been minimized.
This comment has been minimized.
ZhilkinSerg
deleted the
ZhilkinSerg:mapgen-sub-station
branch
Sep 11, 2017
This comment has been minimized.
This comment has been minimized.
Vending machines used the old "re-rolling" item spawning formula to spawn loads of items, they were unintentionally nerfed when we changed the item spawning logic. |
ZhilkinSerg
added this to Done
in Mapgen and overmapgen improvements
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedSep 10, 2017
•
edited
Not that I've dropped randomness in vending machine placement - hope it won't be an issue.