Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] More requirements #21892

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@Maddremor
Copy link
Contributor

commented Sep 15, 2017

I plan on converting armor crafting recipes to using requirements, making this PR first for the new prerequisite reqs I plan on using.

I could add more reqs while I'm at it if anyone has suggestions.

@cainiaowu

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

It would be better if we can change filament requirement from used as component to used as charge.

Currently only filament that are not loaded in the tailoring tool could be used to craft clothing which is a bit counter intuitive, and there are lots complain about it.

@Maddremor

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2017

Frankly, the idea of loading a sewing tool with thread seems strange for me. I'd rather move in the other direction of having the repair action use thread from the inventory and remove the ability for sewing tools to be loaded at all. However, this is outside the scope of this PR.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

It would be better if we can change filament requirement from used as component to used as charge.

That was changed in #20270 and there is possibly no going back. Filament requirement is really better than reloading needles.

Frankly, the idea of loading a sewing tool with thread seems strange for me. I'd rather move in the other direction of having the repair action use thread from the inventory and remove the ability for sewing tools to be loaded at all. However, this is outside the scope of this PR.

That will be addressed in #20569. Sorry for that PR being stalled, but I'm not dropping it and it will be eventually finished and merged.

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

Requirements alone are not testable, this will need at least one example per requirement.

I don't like the large leather/fur requirements. They aren't granular and seem to only exist to make tanned leather pieces useful. This is rather backwards, unless you want to remove the smaller scraps someday and just have all leather be handled as those big tanned sheets.
A more correct way would be to simply have the tanned leathers be cut up into scraps as a part of the tanning process.

@cainiaowu

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2017

Various meat / veggy / eggs could use requirement system.

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

This still needs to be updated.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2018

Marking as Stalled. Feel free to reopen it.

@ZhilkinSerg ZhilkinSerg closed this Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.