Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[CR] More requirements #21892
Conversation
Maddremor
added some commits
Sep 15, 2017
This comment has been minimized.
This comment has been minimized.
|
It would be better if we can change filament requirement from used as component to used as charge. Currently only filament that are not loaded in the tailoring tool could be used to craft clothing which is a bit counter intuitive, and there are lots complain about it. |
This comment has been minimized.
This comment has been minimized.
|
Frankly, the idea of loading a sewing tool with thread seems strange for me. I'd rather move in the other direction of having the repair action use thread from the inventory and remove the ability for sewing tools to be loaded at all. However, this is outside the scope of this PR. |
This comment has been minimized.
This comment has been minimized.
That was changed in #20270 and there is possibly no going back. Filament requirement is really better than reloading needles.
That will be addressed in #20569. Sorry for that PR being stalled, but I'm not dropping it and it will be eventually finished and merged. |
This comment has been minimized.
This comment has been minimized.
|
Requirements alone are not testable, this will need at least one example per requirement. I don't like the large leather/fur requirements. They aren't granular and seem to only exist to make tanned leather pieces useful. This is rather backwards, unless you want to remove the smaller scraps someday and just have all leather be handled as those big tanned sheets. |
This comment has been minimized.
This comment has been minimized.
|
Various meat / veggy / eggs could use requirement system. |
This comment has been minimized.
This comment has been minimized.
|
This still needs to be updated. |
This comment has been minimized.
This comment has been minimized.
|
Marking as Stalled. Feel free to reopen it. |
Maddremor commentedSep 15, 2017
I plan on converting armor crafting recipes to using requirements, making this PR first for the new prerequisite reqs I plan on using.
I could add more reqs while I'm at it if anyone has suggestions.