Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Buildings mod #22054

Merged

Conversation

5 participants
@ZhilkinSerg
Copy link
Contributor

commented Oct 1, 2017

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

There is already one "more locations" mod. Unless there is a good reason for why should this be separate, it shouldn't be a separate mod.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2017

There is already one "more locations" mod. Unless there is a good reason for why should this be separate, it shouldn't be a separate mod.

More locations mod contain large multitile Z-level structures. Locations in current mod are much smaller.

@vache

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

Locations shouldn't be in a mod anyway unless they are in some way inappropriate for mainline inclusion (like missing item/monster spawns, specific to theme of mod that does not match game theme, etc).

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 2, 2017

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2017

Locations shouldn't be in a mod anyway unless they are in some way inappropriate for mainline inclusion (like missing item/monster spawns, specific to theme of mod that does not match game theme, etc).

I would like to move these new locations to core eventually, but they are probably not ready for it yet.

While I agree what we really want is to mainline this content, there's also no good reason to exclude it. I would ask that it have a distinctive name to prevent confusion.

Do you mean I need to change mod ident and/or name?

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 3, 2017

Yes both of those.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2017

I name it more_buildings (More Buildings)!

@secretfire42

This comment has been minimized.

Copy link

commented Oct 3, 2017

Just a comment (hopefully not inhelpful or unwelcome; if so I apologize) - from the 'casual forumgoer who looks at the github' - you guys have a LOT of mods in the game with names like 'extra/more buildings' , and the last time I played with them, half of them were uh, really good, and half of them were uh...errorprone. Its getting to the point where I stopped using them because I couldn't tell what was horribly broken and what was usable. So uh, I'm just going to second that you maineline, when possible, working content. Or at least make it easier to figure out what should be activated and what the real differences are between them all.

Because to 'casual person who nevertheless follows the github and browses the forums' they all kinda look the same from the descriptions you see in world generation. It'd be like if I was playing a strategy game, and I wanted a star trek mod, and they were all named "Star Trek Mod", "Trek Mod", "That Star Trek Mod" and "Mod for Trekkies", its just a tad confusing. Again, I apologize if this is unwanted commentary, I don't mean to discourage or disparage you awesome coders.

@kevingranade kevingranade merged commit f0eb2c0 into CleverRaven:master Oct 6, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 22.649%
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg deleted the ZhilkinSerg:mapgen-extended-buildings branch Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.