Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMetalcraft: crown, ring, and bracelet #22112
Conversation
ituluwituluwzev
added some commits
Oct 8, 2017
This comment has been minimized.
This comment has been minimized.
|
Terminated: data/mods//dda/../../json/items/armor.json: line 1963:3: member not found: name Does this mean that two items cannot have the same "name"? |
Night-Pryanik
reviewed
Oct 9, 2017
| "time": 600000, | ||
| "book_learn": [ [ "jewelry_book", 6 ] ], | ||
| "qualities": [ { "id": "HAMMER", "level": 3 } ], | ||
| "tools": [ [ [ "surface_heat", 10, "LIST" ] ] ], |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Oct 9, 2017
Member
surface_heat group include charcoal smoker and fire nearby tools. They don't fit as metalworking tools here. Better explicitly replace them by soldering iron and integrated toolset.
The same for ring crafting below.
This comment has been minimized.
This comment has been minimized.
|
AFAIK, gold is heated by the burner. Gold is melted at more than 1000 C, common soldering iron can't achieve this temperature. |
This comment has been minimized.
This comment has been minimized.
|
I'll add a proper forge to the recipe. |
ituluwituluwzev
added some commits
Oct 9, 2017
This comment has been minimized.
This comment has been minimized.
|
What is the problem? Do I use copy-from incorrectly? |
Night-Pryanik
reviewed
Oct 9, 2017
| ], | ||
| "components": [ [ [ "gold_small", 3 ] ] ] | ||
| }, | ||
| { |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
Oct 9, 2017
Member
There is an excessive space after the bracket.
You should run your files through the linting tool (http://dev.narc.ro/cataclysm/format.html).
This comment has been minimized.
This comment has been minimized.
ituluwituluwzev
added some commits
Oct 9, 2017
This comment has been minimized.
This comment has been minimized.
|
They all go through the web linter now, but some still don't pass the check. |
This comment has been minimized.
This comment has been minimized.
|
You have to specify the name for each object. |
This comment has been minimized.
This comment has been minimized.
|
It says "All checks have passed." But some commits remain red. Are there problems yet to be fixed? |
This comment has been minimized.
This comment has been minimized.
|
I find this to be better implemented as a mod that's prepackaged. |
This comment has been minimized.
This comment has been minimized.
|
Making adornment out of shiny metal is something that would happen even when cataclysm took place... It is quite generic. |
ituluwituluwzev commentedOct 9, 2017
Forging a crown is suggested here: http://smf.cataclysmdda.com/index.php?topic=5865.msg307755#msg307755.
In jewelry shop and other places, we can find a gallery book with which one may try to replicate ancient crown and various fancy trinkets with gold and silver salvaged from bank vault. In museum, we can occasionally find a Bactrian crown that looks even fancier.
Be it a king, a queen, or an extradimensional prince of blob, who wears the crown is the post-apocalyptic political detail that I leave to the player's decision.