Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metalcraft: crown, ring, and bracelet #22112

Merged
merged 15 commits into from Oct 19, 2017

Conversation

Projects
None yet
5 participants
@ituluwituluwzev
Copy link
Contributor

commented Oct 9, 2017

Forging a crown is suggested here: http://smf.cataclysmdda.com/index.php?topic=5865.msg307755#msg307755.

In jewelry shop and other places, we can find a gallery book with which one may try to replicate ancient crown and various fancy trinkets with gold and silver salvaged from bank vault. In museum, we can occasionally find a Bactrian crown that looks even fancier.

Be it a king, a queen, or an extradimensional prince of blob, who wears the crown is the post-apocalyptic political detail that I leave to the player's decision.

@ituluwituluwzev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Terminated: data/mods//dda/../../json/items/armor.json: line 1963:3: member not found: name

Does this mean that two items cannot have the same "name"?

"time": 600000,
"book_learn": [ [ "jewelry_book", 6 ] ],
"qualities": [ { "id": "HAMMER", "level": 3 } ],
"tools": [ [ [ "surface_heat", 10, "LIST" ] ] ],

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Oct 9, 2017

Member

surface_heat group include charcoal smoker and fire nearby tools. They don't fit as metalworking tools here. Better explicitly replace them by soldering iron and integrated toolset.
The same for ring crafting below.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

AFAIK, gold is heated by the burner. Gold is melted at more than 1000 C, common soldering iron can't achieve this temperature.

@ituluwituluwzev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

I'll add a proper forge to the recipe.

ituluwituluwzev added some commits Oct 9, 2017

@ituluwituluwzev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

What is the problem? Do I use copy-from incorrectly?

],
"components": [ [ [ "gold_small", 3 ] ] ]
},
{

This comment has been minimized.

Copy link
@Night-Pryanik

Night-Pryanik Oct 9, 2017

Member

There is an excessive space after the bracket.
You should run your files through the linting tool (http://dev.narc.ro/cataclysm/format.html).

This comment has been minimized.

Copy link
@ituluwituluwzev

ituluwituluwzev Oct 9, 2017

Author Contributor

Thanks!

ituluwituluwzev added some commits Oct 9, 2017

@ituluwituluwzev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2017

They all go through the web linter now, but some still don't pass the check.

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

You have to specify the name for each object.
The name should not be identical for different objects.

@ituluwituluwzev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2017

It says "All checks have passed." But some commits remain red. Are there problems yet to be fixed?

@Broken-Admin

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

I find this to be better implemented as a mod that's prepackaged.

@ituluwituluwzev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2017

Making adornment out of shiny metal is something that would happen even when cataclysm took place... It is quite generic.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 77ee89d into CleverRaven:master Oct 19, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 22.817%
Details
gorgon-ghprb Build finished.
Details

@ituluwituluwzev ituluwituluwzev deleted the ituluwituluwzev:metalcraft branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.