Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove obsolete mods which are maintained in other repos #22125
Conversation
cainiaowu
added some commits
Oct 9, 2017
This comment has been minimized.
This comment has been minimized.
|
What would this do to old saves? Also see: #20129 |
This comment has been minimized.
This comment has been minimized.
|
Maybe just add "obsolete": true to Arcana for now? Maybe some legacy stuff could be dropped after or right before a stable release? |
This comment has been minimized.
This comment has been minimized.
|
it is 30k lines removed ... |
This comment has been minimized.
This comment has been minimized.
|
@Cyrano7 They have been "obsolete": true for almost a year now, which means they are invisible to new gamer for almost a year, unless someone has a savefile that doesnt break on load with these mods on in newest experimental (which doesnt exist, see chatsvolts issue), we can drop these two mods just fine. |
This comment has been minimized.
This comment has been minimized.
|
10 and 11 months of obsoletion, seems like plenty of notice. |
kevingranade
merged commit cec10e8
into
CleverRaven:master
Oct 13, 2017
cainiaowu
deleted the
cainiaowu:remove-mods
branch
Oct 13, 2017
zakhad
referenced this pull request
Oct 19, 2017
Closed
PK-rebalancing (Latest not old) unable to create character see error. #22201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cainiaowu commentedOct 12, 2017
•
edited
Fix #20326.
Remove obsoleted Arcana and PK Rebalancing mods as both authors expressed that they want them removed from master.
They are maintained in following repo:
Arcana: https://github.com/chaosvolt/cdda-arcana-mod
Pisskop's Rebalancing: https://github.com/pisskop/PKs_Rebalancing
See also
pisskop/PKs_Rebalancing#30
cataclysmbnteam#22