Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete mods which are maintained in other repos #22125

Merged
merged 4 commits into from Oct 13, 2017

Conversation

Projects
None yet
5 participants
@cainiaowu
Copy link
Contributor

commented Oct 12, 2017

Fix #20326.

Remove obsoleted Arcana and PK Rebalancing mods as both authors expressed that they want them removed from master.

They are maintained in following repo:

Arcana: https://github.com/chaosvolt/cdda-arcana-mod

Pisskop's Rebalancing: https://github.com/pisskop/PKs_Rebalancing

See also

pisskop/PKs_Rebalancing#30

cataclysmbnteam#22

@Leland

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

What would this do to old saves?

Also see: #20129

@Cyrano7

This comment has been minimized.

Copy link
Member

commented Oct 12, 2017

Maybe just add "obsolete": true to Arcana for now? Maybe some legacy stuff could be dropped after or right before a stable release?

@pisskop

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2017

it is 30k lines removed ...

@cainiaowu

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2017

@Cyrano7 They have been "obsolete": true for almost a year now, which means they are invisible to new gamer for almost a year, unless someone has a savefile that doesnt break on load with these mods on in newest experimental (which doesnt exist, see chatsvolts issue), we can drop these two mods just fine.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 13, 2017

10 and 11 months of obsoletion, seems like plenty of notice.

@kevingranade kevingranade merged commit cec10e8 into CleverRaven:master Oct 13, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 22.634%
Details
gorgon-ghprb Build finished.
Details

@cainiaowu cainiaowu deleted the cainiaowu:remove-mods branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.