New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astyle map.h #22232

Merged
merged 2 commits into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@Coolthulhu
Contributor

Coolthulhu commented Oct 23, 2017

I wanted to look into splitting off map cache from tinymap as described in #21985, but found that map.h is unstyled, which would make the whole thing more painful.
With the ?w=1 trick (adding ?w=1 at the end of the github URL), the diff adds up to just above 100 lines.

The astyle didn't like some comments after functions and was adding needless breaks. In one case it even broke the line like this:

ter_id ter( int x, int y )
const; // The comment

In those cases, I moved the comments above the functions instead. I did it for whole blocks to avoid situations where only one function out of the block has a comment above it, but others have it after the definition.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 23, 2017

Member

Perfect

Member

kevingranade commented Oct 23, 2017

Perfect

@kevingranade kevingranade merged commit d75f27e into CleverRaven:master Oct 23, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 22.391%
Details
gorgon-ghprb Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment