Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Example buildings to be JSONized #22366
Conversation
Coolthulhu
reviewed
Nov 6, 2017
| } | ||
| } | ||
| } | ||
| ] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Missile computer should be jsonable now. |
ZhilkinSerg
referenced this pull request
Dec 2, 2017
Closed
List of hard-coded mapgen functions to be moved to JSON #21824
This comment has been minimized.
This comment has been minimized.
|
Are you here @SunshineDistillery ? |
This comment has been minimized.
This comment has been minimized.
|
@ZhilkinSerg it seems that you have some experience with implementation of similar changes and it also seems that this PR is obsolete. It would be really great if you can re-implement this in bunch of smaller PRs (with possible changes, of course, it's totally up to you). |
ZhilkinSerg
added
Mods
Mapgen
labels
Apr 2, 2018
ZhilkinSerg
self-assigned this
Apr 3, 2018
ZhilkinSerg
added
(P2 - High)
[JSON]
[C++]
labels
Apr 3, 2018
This comment has been minimized.
This comment has been minimized.
I will pick this up soon. |
ZhilkinSerg
added this to In progress
in Mapgen and overmapgen improvements
Apr 19, 2018
ZhilkinSerg
added
(P3 - Medium)
and removed
(P2 - High)
labels
Jul 29, 2018
mlangsdorf
changed the title
Example buildings to be JSONized [WIP]
[WIP] Example buildings to be JSONized
Sep 11, 2018
ZhilkinSerg
merged commit e3952d7
into
CleverRaven:master
Oct 3, 2018
Mapgen and overmapgen improvements
automation
moved this from In progress
to Done
Oct 3, 2018
ZhilkinSerg
removed their assignment
Oct 3, 2018
This comment has been minimized.
This comment has been minimized.
|
I've added computers and poison gas and linted whole mod in #26030. |
SunshineDistillery commentedNov 6, 2017
•
edited by kevingranade
SUMMARY: Mods "Even more buildings."
These are some example buildings for #21824. It isn't meant to be merged as is; it's in mod form so it's easy to load up and examine the sites.
Rather than just remake cube buildings, I altered them a bit to make them more interesting/realistic. The Missile Silo currently lacks poison gas, a launch computer, and a missile.
For the real thing, I can condense them to single files or leave them as they are.