Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Mutant NPCs" mod. #22497

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@SpencerMichaels
Copy link
Contributor

commented Nov 26, 2017

This PR is split off from #22487. It depends on #22494.

This PR adds a Mutant NPCs mod which adds 21 new NPC classes: one generic mutant and 20 mutants targeted at each of the serum categories. These classes are similar to NPC_NONE, the generic wandering NPC, except that they have effectively drunk/injected several mutagens/serums before spawning. Only some mutations have an effect for NPCs right now, but there are enough to make, say, a bear mutant companion a much better fighter than a regular one.

Aside from adding these NPC classes, the mod doesn't do anything else yet — it's primarily intended to make use of some of my NPC mutation frameworks in the other related PRs (see #22494, #22495, and #22496). I also want to use the trait groups system to add non-mutation starting traits to the regular NPCs, but that will require lua support for groups, which I don't have yet. I hope to eventually add a mutant faction and some associated quests, although some of the ideas that I have in mind require some code additions as well as mods.

If anyone has recommendations for changes or additions, I'd be glad to hear them.

SpencerMichaels added some commits Nov 26, 2017

@SpencerMichaels SpencerMichaels changed the title [WIP] Add "Mutant NPCs" mod. Add "Mutant NPCs" mod. Dec 17, 2017

@SpencerMichaels

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2017

Taking this off of WIP status because I think at least as a first version of the mod this is ready to merge. My only concern is that there might be too many mutants in random spawns because there are 21 new classes and the random selection is a uniform distribution… but since this is a mod, that might actually be what people want.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

This is triggering the debugmsg at https://github.com/sxmichaels/Cataclysm-DDA/blob/ab428e1f3d05ae1047c44e963452ae67eafc3da7/src/npc_class.cpp#L253
Looks like the check wants the mutation category id, but the npc_class is specifying the category name, which is not the same. I'm seeing if I can apply a simple patch for this since I've let this sit for way too long...

@kevingranade kevingranade merged commit 1e3078d into CleverRaven:master Jan 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
gorgon-ghprb Build finished.
Details
@AMurkin

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2018

@kevingranade Astyle regression: f5ef998#r27036628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.