Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[RDY] Move hardcoded hospital mapgen to json #22543
Conversation
ZhilkinSerg
referenced this pull request
Dec 2, 2017
Closed
List of hard-coded mapgen functions to be moved to JSON #21824
ZhilkinSerg
changed the title
Moved hospital mapgen to json
Move hardcoded hospital mapgen to json
Dec 2, 2017
ZhilkinSerg
changed the title
Move hardcoded hospital mapgen to json
[CR] Move hardcoded hospital mapgen to json
Dec 2, 2017
This comment has been minimized.
This comment has been minimized.
rm-code
reviewed
Dec 3, 2017
| "###########........#...x...........r#BB...+...+...BB#``#BB...+...+...BB#", | ||
| "###########r..BB...#.../......BB...r#BB...+...+...BB#``#BB...+...+...BB#", | ||
| "###########r.TBBT..#.../.....TBBT...#....l#...#l....#``#....l#...#l....#", | ||
| "###########.......l#...x...........l########...#######``#######...#######", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This has a trivial merge conflict. Otherwise it looks good to go. |
This comment has been minimized.
This comment has been minimized.
Good, but there is also no loot yet. |
This comment has been minimized.
This comment has been minimized.
|
I suppose it's a fair trade-off for the missing toilets. Why don't you put the WIP tag then? |
ZhilkinSerg
added some commits
Dec 20, 2017
ZhilkinSerg
changed the title
[CR] Move hardcoded hospital mapgen to json
[RDY] Move hardcoded hospital mapgen to json
Dec 20, 2017
This comment has been minimized.
This comment has been minimized.
I guess someone told me not to put both tags ( |
kevingranade
merged commit c9ef1b6
into
CleverRaven:master
Jan 4, 2018
ZhilkinSerg
deleted the
ZhilkinSerg:mapgen-hospital
branch
Jan 4, 2018
ZhilkinSerg
added this to Done
in Mapgen and overmapgen improvements
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.

ZhilkinSerg commentedDec 2, 2017
•
edited
Description
Moved hospital mapgen to json.
It is not the same hospital as hardcoded one, but this one at least has toilets (fixes #18924) ;)
Please give your feedback for new layout!
To-do
GROUP_HOSPITALmonster group (same asGROUP_ZOMBIE, but without dogs)Screenshots