Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Restricts minimum texture size to fix crash during division by zero #22638

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Reviewers
No reviews
Assignees

@codemime codemime

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ZhilkinSerg @codemime
@ZhilkinSerg
Copy link
Contributor

commented Dec 18, 2017 •
edited

I don't know if it is a good solution, but should fix #22596.

Changes:

  • restricts minimum texture size to 128 sprites wide and 256 sprites high;
  • adds debug message about 0 max_texture-dimensions.

Test build (Win64 without data):

Unzip exe and dlls to existing Catcalysm folder, run Cataclysm-Tiles.exe and try to start new game or change Use tiles option in menu.
@ZhilkinSerg
Restricts minimum texture size to fix crash during division by zero 
- restricts minimum texture size to 128 sprites wide and 256 sprites high;
- adds debug message about 0 `max_texture`-dimensions.

Fixes #22596
Loading status checks…
329dcc4

@ZhilkinSerg ZhilkinSerg changed the title Restricts minimum texture size to fix crash during division by zero [RDY] Restricts minimum texture size to fix crash during division by zero Dec 18, 2017

@ZhilkinSerg

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Dec 21, 2017

@kevingranade, @codemime, @Coolthulhu, @Rivet-the-Zombie

Would someone please review and merge this PR asap. The crash is game breaking since build 7002.

@codemime codemime self-assigned this Dec 21, 2017

ZhilkinSerg added a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Dec 21, 2017

@ZhilkinSerg
Include changes from CleverRaven#22638
5197445

@ZhilkinSerg ZhilkinSerg referenced this pull request Dec 21, 2017

Closed

[WIP] Performance boost for SDL ASCII drawing #21748

3 of 5 tasks complete

@codemime codemime merged commit 3e80249 into CleverRaven:master Dec 21, 2017
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 22.76%
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg deleted the ZhilkinSerg:sdl-fix-atlas-tile-split branch Dec 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.