Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[RDY] Fix generation of subway stations and tunnels on Z-level -2 #22727
Conversation
ZhilkinSerg
changed the title
Fix generation of subway stations and tunnels on Z-level -2
[RDY] Fix generation of subway stations and tunnels on Z-level -2
Jan 10, 2018
kevingranade
merged commit e6ed7a3
into
CleverRaven:master
Jan 16, 2018
ZhilkinSerg
deleted the
ZhilkinSerg:mapgen-subway-fix
branch
Jan 23, 2018
ZhilkinSerg
added this to Done
in Mapgen and overmapgen improvements
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedJan 10, 2018
•
edited
What was changed:
Fixes #22714.
Additional information:
Sub levels are generated by
generate_subfunction based on previous Z-levels. Running of this function starts from Z-level -1. Previously subway tunnels were generated on the same level, so there were no issues. I forgot to change return valuerequires_subtotruewhen there are subway stations on Z-level -1, when I moved subway stations and tunnels to Z-level -2 in #22550. Z-level -2 was simply not generated when there were no any overmap specials on the overmap requiring this level (these are labs, mines, silos, etc). When city size was set to large values there were simply not enough place on some of the overmaps to include these overmap specials, therefore Z-level -2 was not generated.