Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Replaced `add_spawn` with `place_spawn` (Step 2) #22852

Merged
merged 3 commits into from Feb 5, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
  
Done in Mapgen and overmapgen improvements
Milestone
No milestone
2 participants
@ZhilkinSerg @kevingranade
@ZhilkinSerg
Copy link
Contributor

commented Feb 2, 2018

Continues #22847

What was changed:

  • add_spawn function calls were replaced with place_spawn function calls;
  • several monster groups were added to monstergroup.json;
  • some magic numbers were replaced with SEEX/SEEY defines;
  • some inappropriate usages of SEEX were replaced with SEEY.

This was referenced Feb 2, 2018

Open
Merged

@kevingranade kevingranade merged commit d658856 into CleverRaven:master Feb 5, 2018
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 23.108%
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg deleted the ZhilkinSerg:mapgen-spawn-groups-step2 branch Feb 5, 2018

@ZhilkinSerg ZhilkinSerg referenced this pull request Feb 7, 2018

Merged

[RDY] Rollback recent spawn function changes in hardcoded mapgen #22898

@ZhilkinSerg ZhilkinSerg added this to Done in Mapgen and overmapgen improvements Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.