Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[RDY] Replaced `add_spawn` with `place_spawns` (Step 3) #22854
Conversation
ZhilkinSerg
added some commits
Feb 2, 2018
ZhilkinSerg
referenced this pull request
Feb 2, 2018
Open
Replace add_spawn() calls in mapgen with place_spawn() #3951
kevingranade
merged commit 184f005
into
CleverRaven:master
Feb 5, 2018
ZhilkinSerg
deleted the
ZhilkinSerg:mapgen-spawn-groups-step3
branch
Feb 5, 2018
ZhilkinSerg
referenced this pull request
Feb 7, 2018
Merged
[RDY] Rollback recent spawn function changes in hardcoded mapgen #22898
ZhilkinSerg
added this to Done
in Mapgen and overmapgen improvements
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedFeb 2, 2018
Continues #22847 and #22852 (includes changes from both).
What was changed:
add_spawnfunction calls were replaced withplace_spawnsfunction calls;monstergroup.json;SEEX/SEEYdefines;SEEXwere replaced withSEEY.