Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate veh_interact.cpp #2291
Conversation
This comment has been minimized.
This comment has been minimized.
CataJenkins
commented
Aug 2, 2013
|
Build successful! |
This comment has been minimized.
This comment has been minimized.
|
I actually can't replicate this crash on Cygwin even prior to merging this, so if someone else who can wants to test this and post here whether or not this works that would be very useful. (Crash is described here.) |
i2amroy
added a commit
that referenced
this pull request
Aug 4, 2013
i2amroy
merged commit c68a4ef
into
CleverRaven:master
Aug 4, 2013
kevingranade
deleted the
kevingranade:vehicle-interact-crash-fix
branch
Apr 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedAug 2, 2013
Check cpart for validity before calling can_unmount() with it.
Thanks Rorundo for finding the problem.