Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Fix V1 migration for StatsThroughSkills mod #23010

Merged
merged 5 commits into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@ZhilkinSerg
Copy link
Contributor

commented Feb 22, 2018

Fixes #22914

What was changed:

  • added function_exists() helper function to autoexec.lua;
  • migration from V1 of STS mod is now done for characters older than 1 day in game version with exposed calendar:days() function or any characters older than 1 year.
@Soyweiser

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2018

I don't use this mod (so have not tested this so don't take my comment as approval of the code or anything) but damn a lot of people have been complaining and talking about this. So good you fixed it!

@kevingranade kevingranade merged commit c9d2087 into CleverRaven:master Mar 1, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 23.37%
Details
gorgon-ghprb Build finished.
Details

@ZhilkinSerg ZhilkinSerg deleted the ZhilkinSerg:mod-fix-sts-20180222 branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.