Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for #22686 #23349

Merged
merged 4 commits into from Apr 26, 2018
Merged

Conversation

fungusakafungus
Copy link
Contributor

@fungusakafungus fungusakafungus commented Apr 1, 2018

Tests whether profession-specific items in holsters can be put back once
removed.

Fixes #22686.

  • do tests have RL_Classes mod enabled? -> No
  • should they? -> yes, added a matrix job to travis to test with RL_Classes mod. More mods can be added later

Tests whether profession-specific items in holsters can be put back once
removed.
@fungusakafungus fungusakafungus force-pushed the test_holster branch 2 times, most recently from 9ad3066 to 39b2030 Compare April 1, 2018 22:40
@fungusakafungus fungusakafungus changed the title Add a test for #22686 WIP Add a test for #22686 Apr 1, 2018
@fungusakafungus
Copy link
Contributor Author

So, the new test passes for default dda mod, but it fails for RL_Classes if run locally:

~/src/Cataclysm-DDA](test_holster)$ ./tests/cata_test starting_items --mods=RL_Classes
Starting the actual test at Mon Apr  2 13:41:09 2018

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cata_test is a Catch v1.9.6 host application.
Run with -? for options

-------------------------------------------------------------------------------
starting_items
-------------------------------------------------------------------------------
new_character_test.cpp:93
...............................................................................

new_character_test.cpp:173: FAILED:
  REQUIRE( failures.empty() )
with expansion:
  false
with message:
  wizard ANTIFRUIT  sheath: Couldn't put item back to holster

(it is also the only test that fails with RL_Classes)

What do I do now? Can someone help me to enable tests for other mods? Which mods?
@kevingranade is this test what you meant in #22686 (comment) by "profession consistency
checking"?

@ZhilkinSerg ZhilkinSerg added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` labels Apr 2, 2018
@kevingranade
Copy link
Member

Yes that's exactly it.

should they?

If you want to fix it go ahead, but it's mergeable without it.

@fungusakafungus
Copy link
Contributor Author

This one shows the problem in #22686

@fungusakafungus fungusakafungus changed the title WIP Add a test for #22686 Add a test for #22686 Apr 8, 2018
@fungusakafungus
Copy link
Contributor Author

Please take another look, I think this is mergable now.
This adds another (10th) matrix job to travis, for running test with selected mods enabled.

@kevingranade kevingranade merged commit 3adf3df into CleverRaven:master Apr 26, 2018
@fungusakafungus fungusakafungus deleted the test_holster branch April 26, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants