Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upEncapsulate WORLD::world_path into a function #23416
Conversation
ZhilkinSerg
added
[C++]
Code: Astyle / Optimization
labels
Apr 8, 2018
codemime
reviewed
Apr 8, 2018
src/game.cpp
Outdated
| @@ -13760,5 +13760,5 @@ std::string game::get_player_base_save_path() const | |||
|
|
|||
| std::string game::get_world_base_save_path() const | |||
| { | |||
| return world_generator->active_world->world_path; | |||
| return world_generator->active_world->path(); | |||
This comment has been minimized.
This comment has been minimized.
codemime
Apr 8, 2018
Member
It would be nice to rename it to something like folder_path(). Just path has a too generic meaning.
ZhilkinSerg
merged commit 00e2d13
into
CleverRaven:master
Apr 13, 2018
BevapDin
deleted the
BevapDin:lad
branch
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BevapDin commentedApr 8, 2018
Saves us from updating it whenever the name of the world changes.