Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for "temperature too low" #23518
Conversation
Moumix3
added some commits
Apr 17, 2018
ZhilkinSerg
added
[C++]
<Bugfix>
labels
Apr 17, 2018
ZhilkinSerg
requested changes
Apr 17, 2018
src/weather_gen.cpp
Outdated
| @@ -42,7 +42,7 @@ w_point weather_generator::get_weather( const tripoint &location, const time_poi | |||
| double A( raw_noise_4d( x, y, z, modSEED ) * 8.0 ); | |||
| double W; | |||
|
|
|||
| const double now( time_past_new_year( t ) / calendar::year_length() ); // [0,1) | |||
| const double now( ( time_past_new_year( t ) + calendar::season_length() / 2 ) / calendar::year_length() ); // [0,1) | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks for the tip on Astyle, ZhilkinSerg. I was not understanding what I did wrong, but didn't think of splitting the line because it was too long. :) |
This comment has been minimized.
This comment has been minimized.
|
Fixes #23502 |
ZhilkinSerg
self-assigned this
Apr 18, 2018
ZhilkinSerg
approved these changes
Apr 18, 2018
ZhilkinSerg
removed their assignment
Apr 18, 2018
ZhilkinSerg
merged commit 5f5b87b
into
CleverRaven:master
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Moumix3 commentedApr 17, 2018
Fix for "temperature too low" after @BevapDin's changes on time classes in weather_gen.cpp #23327
https://discourse.cataclysmdda.org/t/latest-experimental-too-cold-freezing-with-warm-clothes/15260