Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for lost items on save/load #2357
Conversation
This comment has been minimized.
This comment has been minimized.
|
I luff you. Putting back playing until this is merged in. |
This comment has been minimized.
This comment has been minimized.
CataJenkins
commented
Aug 8, 2013
|
Build successful! |
This comment has been minimized.
This comment has been minimized.
|
I don't believe this is correct, see #2358. This change moves the call to u.inv.load_invlet_cache() to after the code that loads the inventory. That code doesn't have a catch-all else, so it just completely ignores all of the invlet cache lines (which start with 'P'). Then the call to load_invlet_cache occurs, but the ifstream is at the end of the file, so it immediately ends with an empty invlet cache. Please correct me if you think I'm wrong, but I believe that this PR will break the invlet cache feature. |
This comment has been minimized.
This comment has been minimized.
|
Ahh yes, I screwed up there. |
1942rob commentedAug 8, 2013
Issue #2356