Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for lost items on save/load #2357

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@1942rob
Copy link
Contributor

commented Aug 8, 2013

Issue #2356

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2013

I luff you. Putting back playing until this is merged in.

@CataJenkins

This comment has been minimized.

Copy link

commented Aug 8, 2013

Build successful!
Refer to this link for build results: http://ci.narc.ro/job/Cataclysm-PullRequests/245/

@ianestrachan

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2013

I don't believe this is correct, see #2358.

This change moves the call to u.inv.load_invlet_cache() to after the code that loads the inventory. That code doesn't have a catch-all else, so it just completely ignores all of the invlet cache lines (which start with 'P'). Then the call to load_invlet_cache occurs, but the ifstream is at the end of the file, so it immediately ends with an empty invlet cache.

Please correct me if you think I'm wrong, but I believe that this PR will break the invlet cache feature.

@1942rob

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2013

Ahh yes, I screwed up there.

@1942rob 1942rob closed this Aug 8, 2013

@1942rob 1942rob deleted the 1942rob:fix-load-inv branch Aug 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.