Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged DELETE_WORLD to WORLD_END. #23690
Conversation
This comment has been minimized.
This comment has been minimized.
|
Please add "reset world" states to the option instead of removing the "delete world" states.
|
BevapDin
reviewed
May 9, 2018
src/options.cpp
Outdated
| add_retry(name, value); | ||
| options[ name ].setValue( value ); | ||
| } | ||
| } | ||
|
|
||
| std::string options_manager::migrateOption( const std::string &name ) | ||
| { | ||
| return !mMigrateOption[name].empty() ? mMigrateOption[name] : name; |
This comment has been minimized.
This comment has been minimized.
BevapDin
May 9, 2018
Contributor
Please don't query maps like that if the key may not be contained in it. This creates a key/value in the map. Use map::find to get an iterator to the existing entry:
const auto iter = mMigrateOption.find( name );
return iter != mMigrateOption.end() ? iter->second : name;Than you can even make the function const, which it logically should be as it does not change the option_manager object.
OzoneH3
changed the title
Changed DELETE_WORLD to RESET_WORLD.
Changed DELETE_WORLD to WORLD_END.
May 9, 2018
OzoneH3
force-pushed the
OzoneH3:reset_world
branch
2 times, most recently
May 9, 2018
This comment has been minimized.
This comment has been minimized.
|
Jenkins rebuild |
OzoneH3
added some commits
May 8, 2018
OzoneH3
force-pushed the
OzoneH3:reset_world
branch
to
a3ec191
May 14, 2018
kevingranade
merged commit d8f81b7
into
CleverRaven:master
May 17, 2018
OzoneH3
deleted the
OzoneH3:reset_world
branch
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
OzoneH3 commentedMay 8, 2018
•
edited
Closes #23688