Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urban Development Test City #23748

Closed
wants to merge 29 commits into from

Conversation

Projects
None yet
5 participants
@acidia
Copy link
Contributor

commented May 17, 2018

This ISN'T the fifth step to implementing the urban development concept #21488. This is the test build that I'm currently doing bug testing on. It contains buildings up to 75 (-NPCs). There are two mods now, Urban Development will add all 75 buildings to your game with min occurrences set to 0 so they won't interfere with other specials. Prototype City is a single static city that spawns all of the buildings in one place (no where else) and represents the style of city I'm shooting for eventually.

The other half of the buildings







This is what the static city looks like on the over map at the moment.

Descriptions for the buildings are in the forum thread.

Now working on updating all of the subways to reflect the wonderful improvements by ZhilkinSerg and the minor errors mentioned on the forum.

Forum Thread: https://discourse.cataclysmdda.org/t/spoilers-urban-development/14068

acidia added some commits May 17, 2018

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented May 17, 2018

Awesome!

@budg3

This comment has been minimized.

Copy link
Contributor

commented May 17, 2018

In Urban_Development - overmap_terrain.json:
0:16:34.828 WARNING : Deprecated foreground color suffix was used: (lt) in (ltgreen). Please update mod that uses that.
0:16:34.875 WARNING : Deprecated foreground color suffix was used: (lt) in (i_ltgray). Please update mod that uses that.

acidia added some commits May 17, 2018

@acidia

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2018

Added the z-2 subways and fixed color, tracking that the subway tunnels are defaulting to sewers for some reason.

acidia added some commits May 17, 2018

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

@acidia try running the mapgen through the weblinter. If that doesn't work, try inspecting the file with a hexeditor and remove any UTF code.

@acidia

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2018

I think it is the same line ending problems that I ran into with the other parts. Everything was ok when I could drag all of the files onto the browser to upload them but when I attempt to edit an existing file the browser converts all EOL characters from LF to CR LF which breaks the linting.

@Wishbringer

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

I use the free software SourceTree and git bash.

@ZhilkinSerg ZhilkinSerg added the Mods label May 18, 2018

acidia added some commits May 18, 2018

acidia added some commits May 18, 2018

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2018

Do you need this to be merged?

@acidia

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2018

Nope, this is just my giant tracker for all the parts that need to be updated and for anyone to test them out. I cut off ten buildings at a time and put them in little PRs. I typically work on jsons when I don't have much free time because they are easier to pick up and put down. So, based on my work schedule I'll probably be working on this in 1.5 - 2 weeks, as soon as the faction base is neat and tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.