Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turret tile layering fix #23756

Merged
merged 4 commits into from May 19, 2018

Conversation

Projects
None yet
5 participants
@budg3
Copy link
Contributor

commented May 18, 2018

This removes the location": "on_roof" from the turret_mount and instead adds it to the turrets in vanilla, Vehicle Additions Pack and Tanks and Other Vehicles instead. This potentially fixes #23646 but requires some testing in case this breaks something.

budg3 added some commits May 18, 2018

Add files via upload
removed on_roof from turret_mount
@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

First impressions: it doesn't cause the turrets to shoot the vehicle they're mounted on, but it does make the turret mount invisible.

It's working so far.

Dismounting and remounting both turret mount and mounted gun are working.

@budg3

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2018

Is there a location slot that can be used instead for the turret mount? I tried keeping on_roof on the turret mount and adding it to the turrets, but that makes the game complain about multiple parts being in the on_roof slot.

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

@budg3 Superficially the game works as intended when the mounted guns are given the on_roof. It would be good to add a new layer though.

@ZhilkinSerg ZhilkinSerg merged commit c4c0045 into CleverRaven:master May 19, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 23.435%
Details
gorgon-ghprb Build finished.
Details
@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented May 19, 2018

Damn, missed that one. location: on roof could be only added to turret abstract, there's no need to manually add it to every turret as they all use copy-from mechanic.

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented May 19, 2018

Damn, missed that one. location: on roof could be only added to turret abstract, there's no need to manually add it to every turret as they all use copy-from mechanic.

I can merge PR today if you make it.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented May 19, 2018

@xottoplus

This comment has been minimized.

Copy link
Contributor

commented May 26, 2018

blazemod's blob turrets are missing of on_roof flag. (blaze_blob_parts.json)
there isn't copy-from mechanic, so it must add to individual turrets.
some blob turret has location flag(center) already. this parts don't need to add on_roof.

@budg3

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2018

@xottoplus
Thanks for the heads up! Issued a new PR #23853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.