Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTurret tile layering fix #23756
Conversation
budg3
added some commits
May 18, 2018
ZhilkinSerg
added
[JSON]
Mods
SDL: Tiles / Sound
<Bugfix>
labels
May 18, 2018
This comment has been minimized.
This comment has been minimized.
|
First impressions: it doesn't cause the turrets to shoot the vehicle they're mounted on, but it does make the turret mount invisible. It's working so far. Dismounting and remounting both turret mount and mounted gun are working. |
This comment has been minimized.
This comment has been minimized.
|
Is there a location slot that can be used instead for the turret mount? I tried keeping on_roof on the turret mount and adding it to the turrets, but that makes the game complain about multiple parts being in the on_roof slot. |
This comment has been minimized.
This comment has been minimized.
|
@budg3 Superficially the game works as intended when the mounted guns are given the on_roof. It would be good to add a new layer though. |
ZhilkinSerg
merged commit c4c0045
into
CleverRaven:master
May 19, 2018
This comment has been minimized.
This comment has been minimized.
|
Damn, missed that one. |
This comment has been minimized.
This comment has been minimized.
I can merge PR today if you make it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
blazemod's blob turrets are missing of on_roof flag. (blaze_blob_parts.json) |
This comment has been minimized.
This comment has been minimized.
|
@xottoplus |
budg3 commentedMay 18, 2018
This removes the location": "on_roof" from the turret_mount and instead adds it to the turrets in vanilla, Vehicle Additions Pack and Tanks and Other Vehicles instead. This potentially fixes #23646 but requires some testing in case this breaks something.