Replace instant healing with slow healing effects.

[Vasyan2006]

Medical items will not heal immediately, but apply healing over time effects.

• Add item flags "bandages" for bandages, "bandages_weak" for gauze, "disinfectant" for disinfectants and "disinfectant_weak" for disinfected rags and cotton balls. First aid kits have both flags,
• Using these items will apply effects "bandaged" and "disinfected" on the body part. Intensity depends on first aid skill (4 at level 0, 16 at level 6). First aid kits apply both effects and provide twice more, "_weak" items provide twice less,
• Using the same item again will reapply effect, so 10 bandages will not heal 10 times faster,
• Each intensity level lasts for 6 hours, maximum ammount is 16,
• New variables: "damage_bandaged" and "damage_disinfected". It is damage on the body part when medicine was applied, so this damage can be healed. New damage will not be healed by previous bandages,
• Taking damade may remove some intensity levels, average ammount is damage/5,
• Default healing rate is 0.0002 HP per level per turn, sleeping increases this value twice, hidden health may increases or decrease it twice, having both effects (bandaged and disinfected on the body part) will increase rate twice,
• Only first 8 intensity levels will be included in calculations, having more will allow to get healing for longer time with max rate,
• Applying bandages at 0 first aid skill will provide 7.2 HP healing, applying bandages and disinfectant at 6 skill will heal for 46 HP during first 24 hours and more later on,
• Something else I forgot to mention.

[cainiaowu]

Will there be some refactoring for broken limb healing?
I like the "Taking damade may remove some intensity levels" part instead of reseting whole healing process.

[Vasyan2006]

Broken limb recovery was not changed so it will be the same as before.

[pisskop]

What about skill gain for self-learners?

[Night-Pryanik]

Both head_power and torso_power equals to zero by default and can be completely removed.

[Night-Pryanik]

Can be removed as well.

[Vasyan2006]

Done.

[Night-Pryanik]

Maybe you meant || instead of && here?

[Vasyan2006]

Only first aid kits have both flags and they apply both effects with higher intensity to compensate hight ammount of materials.

[Night-Pryanik]

Please add _ for translation here and below.

[Vasyan2006]

Done.

[Vasyan2006]

@pisskop Edit skill gain, so it should be on the same level as before.

[kevingranade]

See #7029 and #16017 (comment)
For previous discussion on the topic.

Tl;dr, I love this change.

[cainiaowu]

It would be great if healing rate is jsoned and easily modify by mod.
Adding some document about it wont hurt either.
Also some mutation should be able affect this healing rate.

[Vasyan2006]

I will move all coefficients to jsons and try to implement other mentioned features, so new version will be "soon"(r)(tm).

[BevapDin]

Consider iterating over all body parts via something like for( const body_part bp : all_body_parts ) { ...

Note that body_part is implicitly convertible to an integer, so you can use it directly as index into an array (e.g. no separate int variable needed).

[Vasyan2006]

But all_body_parts includes feets and hands, so it can not be used here directly.

[BevapDin]

Why are you accessing the effects map directly instead of using the function in Creature, like get_effect?

[Vasyan2006]

Because of my low skill. It should look beter now.

[BevapDin]

Several lines above can be replaced with

effect &e = get_effect( effect_bandaged, bp );
if( !e.is_null() ) {

[BevapDin]

There is a space before the semicolon

[BevapDin]

These new members are not saved / loaded anywhere.

[Vasyan2006]

Fixed. It was tested without reloading.

[Vasyan2006]

New version:

• Add "bandages_power", "bandages_scaling", "disinfectant_power" and "disinfectant_scaling" coefficients for healing items. They work similar way as "limb_power" but apply intensity levels of healing effects instead of direct healing,
• Effects "bandaged" and "disinfected" can be easily modded in jsons,
• Taking damage by broken limbs will not reset mending, but will revert it by 5% per 1 damage,
• First aid kits will not cure infections.

[Night-Pryanik]

Indent these as well.

[Vasyan2006]

It does not look much better after Astyle with --style=1tbs --attach-inlines --indent=spaces=4 --align-pointer=name --max-code-length=100 --break-after-logical --indent-classes --indent-preprocessor --indent-switches --indent-col1-comments --min-conditional-indent=0 --pad-oper --unpad-paren --pad-paren-in --add-brackets --convert-tabs.

[Night-Pryanik]

effect.cpp is in astyle_blacklist. It can violate astyle if needed.

[Vasyan2006]

Must rebuilt this PR on new version, overwise it creates too much conflicts.

[Night-Pryanik]

Duplicate of bandages_makeshift above?

[Vasyan2006]

Yes, it was.

[Night-Pryanik]

You are constantly working on your PR. Consider adding [WIP] prefix to its name until you think it is finished.

[Vasyan2006]

It was rebase, looks like nothing was broken.

[Vasyan2006]

New healing properties will be displayed in item description.

[Vasyan2006]

Add makeshift bandages crafted from rags only without any skill. Advanced version requires cooking skill. So almost every character will be able to craft most simple remedy.

[Night-Pryanik]

You can use copy-from from bandages_makeshift for this and for boiled variants.

[Vasyan2006]

Done.

[Night-Pryanik]

As direct healing is no longer the case, you could remove limb_power, head_power and torso_power from here and from the jsons.

[Vasyan2006]

I think it is a bad idea to remove working game mechanic from a sandbox game. limb_power is now an optional parameter and removed from jsons (but can be restored).

[Night-Pryanik]

limb_power now equals to zero in case of all healing meds. Should be removed?

[Night-Pryanik]

Excessive space before the closing bracket here and in the similar block below.

[Night-Pryanik]

Could this be moved up to the if( damage_bandaged[i] <= 0 ) { as another (||) option?

[Vasyan2006]

This check is separated for the case if the limb is at full HP but still have damage_bandaged and bandaged effect (it was healed by nanobots, for example).

[Vasyan2006]

Add "used_up_item" for drugs, so chloroform rag will not be applied to a body part but can be used in the correct way.

[Coolthulhu]

has_effect gets effect on the inside, so you're getting the effect twice.
Instead you could call get_effect and then check if it was null by calling e_bandaged.is_null().

[Coolthulhu]

Why do you need those "hp disinfected", "hp bandaged" variables? They make the whole thing pretty ugly and hard to maintain.
Without them, you could rely entirely on effects, which would be much cleaner.

[Coolthulhu]

You could merge those into something like this:

struct scaled_effect_data {
    efftype_id effect;
    float base;
    float scaling;
};
std::vector<scaled_effect_data> scaled_effects;

Then, instead of checking if( bandages_power > 0), you'd iterate over scaled_effects and apply all of those, without checks (checks could be done at load time).
This would be more generic, so if later someone wanted to add a new effect, say "immobilized", "moistened", "wound sewn" and so on, it wouldn't need any extra work to work.

[Vasyan2006]

"disinfectant_power " and "disinfectant_scaling" use the same mechanic as "limb_power" and "limb_scaling", so I used the same code.
Creating new structures sounds good, but is too complicated for me right now.

[Coolthulhu]

Why do you have those checks?
Couldn't it all just rely on effects?

[Vasyan2006]

There are nonstandart reasons of removing these effects:

• taking damage,
• medicated wounds was healed, but character has another wounds on the same limb,
• it was healed by sleeping or nanobots.
  Different reasons require different messages.

[Vasyan2006]

"hp disinfected" and "hp bandaged" are required to separate medicated damage and damage taken after using healing items, so new damage will not be healed. And player must apply new healing item after evey combat.

[Coolthulhu]

"hp disinfected" and "hp bandaged" are required to separate medicated damage and damage taken after using healing items, so new damage will not be healed.

You could control it by decreasing existing effect power on new damage instead.

[Vasyan2006]

Taking damage can reduce intensity of healing effects (i.e. healing rate), but it is calculated separately. IRL taking new damage may not destroy bandages on another part of the limb, so I prefer to have both mechanics.

[Xhuis]

Pretty late to the party, but could I ask your reasoning on removing the ability to cure infections with first aid kits? That's a large change that didn't received very little attention and probably flew under the radar for a lot of people because it was mentioned in one line of a PR that doesn't even mention the change except in the comments.

[ZhilkinSerg]

but could I ask your reasoning on removing the ability to cure infections with first aid kits?

The reason is first-aid kits do not contain antibiotics which can kill infection settled all over the body.

[Xhuis]

I'll post this from a discussion I had on the subject elsewhere:

Of the three first aid kits I come in contact with every day (the one in my workplace and the two in my house), all three of them have antibiotic ointment and supplies for treating infections.

Correct me if I'm wrong, but infected wounds are on certain body parts in-game. Having a bite turn bad on your right arm doesn't mean it's all over your body, just that the bite is infected; I always viewed the death-point, where you "succumb" to the infection, as the point of no return where it surpasses the immune system.

The Red Cross recommends packing a family first aid kit with antibiotic ointment for treating localized infections, and some Amazon searching tells me that the majority of first aid kits that aren't slim and compact come with it. I'm not a medical expert, but I think it's still plausible that the majority of first aid kits you find out in the world should come with antibiotics handy. This was even clearly a consideration, since improv. first aid kits don't have the infection healing and normal ones do.

If need be, maybe the current first aid kit can be made into a "compact" or "travel-sized" first aid kit, and a larger, bulkier version with maybe 0.5 L of volume per kit could have the disinfecting properties? The thought that every single FAK in New England lacks any kind of treatment for infections is baffling to me.

[Vasyan2006]

family first aid kit

This is the main difference. Common family first aid kit is a drawer full of different medical items. Some first aid cupboards located in large organisations may even contain defibrillators and other complex equipment. They are represented by all medical supplies you can find in houses.
But ingame kits are slim and compact "travel-sized", so they have only most important items for emergency situations. They have disinfectant to cleam wound immediatly and prevent infections, but are useless if the infection has spreaded into entire body. In this case wounded person must go to doctor and receive correct threatment of antibiotics and other remedies.

[Mecares]

Neither the description nor the crafting recipe contain antibiotics and adding them to the recipe would make crafting them significantly harder.

/edit: Maybe it should apply the painkiller effect considering it requires aspirin or codeine to craft.

[ZhilkinSerg]

Actually I'm all-in for changing how infection cure is working, but it is not about adding infection cure to back to medkit. We should instead change how antibiotics are working - no immediate cure after a single dose (unless dose is really high which only works for certain infections in real life), but regular intake for a certain amount of time.

Anyway the thing is medkits should not be some miracle "healing potions" - they are just a bundle of disinfectant, bandage and anesthetic/painkiller.

[Vasyan2006]

Anyway the thing is medkits should not be some miracle "healing potions" - they are just a bundle of disinfectant, bandage and anesthetic/painkiller.

I made such changes, just need to polish them before releasing.

[Amariithynar]

@Vasyan2006 @Mecares @ZhilkinSerg You're flatly wrong on first aid kits. Just one look at the description and required materials to craft them would have shown you that, as well as simply looking at first aid kits in reality. These aren't dollar store "first aid kits" that are little more than some bandages, maybe some gauze, and some half-assed medical tape.

http://cdda-trunk.chezzo.com/1st_aid/craft straight from the code itself.

Description: A full medical kit, with bandages, local anesthetics, and rapid healing agents. Used for healing large amounts of damage.

Components required:
20x medical tape OR 40x duct tape
10x aspirin OR 2x codeine
1x disinfectant OR 1x thyme oil OR 1x antiseptic powder OR 250x ethanol OR 250x denatured alcohol
10x saline solution OR 20x saline eye drop
3x bandage OR 1x hemostatic powder

Third and fourth line right there are antiseptics. Saline solution is a sterile salt water solution where the salt level is isotonic to body salt levels (which is why it's used as an IV-borne hydrating agent as well as a means to carry intravenous drugs into someone's system). Saltwater is inimical to almost all forms of microbial life by virtue of the effect salt has on cells; it draws water out from them, which destroys microbes, and in the case of inflamed tissues, helps reduce inflammation by drawing off excess fluid in the damaged cells, as well. You do not need an oral antibiotic to fight off an infection unless it's a deep, suppurating wound that has been left uncleaned and infected for so long it's actually oozing pus naturally, or an internal infection that cannot be cleaned, as what occurs with food poisoning. As all infections we're dealing with are surface wounds, basic antiseptic treatment is more than sufficient for dealing with them unless left for days without even being cleaned properly.

Even cheap compact kits come with disinfectant wipes like https://www.toolstation.com/shop/Workwear+%26+Safety/d70/Fire+%26+First+Aid/sd530/HSE+Travel+First+Aid+Kit/p62708 or http://www.gapyeartravelstore.com/solotrekk-pocket-travel-first-aid-kit.html and proper car-sized travel kits come with much more: http://www.firstaid.co.uk/Foreign-Travel-First-Aid-Kits-PK360/ or https://www.bunnings.com.au/protector-75-piece-home-and-travel-c-compliant-first-aid-kit_p6100257 or https://survivalworldhq.com/products/safe-wilderness-survival-car-travel-first-aid-kit-medical-bag-outdoors-camping-hiking-emergency-kit-treatment-4-sections-pack whilst ambulance kits are like this: http://www.stjohnsupplies.co.uk/products/First-aid-kits/Workplace-kits/Travel-BSI-compliant-kits/Travel-standard-workplace-first-aid-kit-St-John-Ambulance or https://shopsafetyproducts.ca/description.php?sid=2&cid=4&id=47 and even Red Cross notes what a first aid kit should contain: http://www.redcross.ca/training-and-certification/first-aid-tips-and-resources/first-aid-tips/kit-contents

Medkits are by no means something that heals wounds immediately, like they were before this was initially implemented, don't get me wrong on appreciating that aspect, but first aid kits SHOULD, by any standard, be able to treat infections. Even the Improvised First Aid Kits mandate the use of either honey (which is antiseptic by virtue of its extremely high sugar concentration) or hard alcohol (which is, again, antiseptic).

Change it to not be a binary healing function, like you've done with the wound damage healing, sure, but don't break common sense and actual realism in a bid for increased "realism".

[Mecares]

It is sad how Amariithynar is not able or is unwilling to understand the difference between cleaning a wound with disinfectant and treating an infection that has spread through the body, especially considering his condescending tone.
Nobody says First Aid kits should be unable to disinfect fresh wounds but neither their description nor their crafting recipes contain antibiotics.
If antibiotics are far too rare in game we could look into that, but I expect weeks after an apocalyptic outbreak most antibiotics to be looted and used.

[Xhuis]

Weeks, certainly, but as far as I'm aware the game is set merely a day or two after the world ended. It's why fast-spoiling food like milk is still fresh for a while even without power. The end came too savagely and quickly for people to prepare much. There was a wave of panic, and once that was over, everyone was dead except for a tiny few survivors.

Antibiotics are far too rare in the current version of the game, but this fact can be addressed by making infections less threatening as well. I'm trying to address both in the PR I linked earlier by adding a method to stave off the infection until you're able to find proper treatment to remove it.

[ZhilkinSerg]

Anyone is free to contribute. Overhaul of wound and disease treatment systems to be more realistic is what we are interested in and current PR is a step in right direction. Leave instant healing potions to another games, but some updates to FAK or drugs would still be welcome.

[Amariithynar]

Agreed, @ZhilkinSerg. As I said, I'm all for removing the instant healing potion aspect of first aid (I actually refused to use them as much as possible because of how 'cheaty' it felt, keeping it to disinfectant-soaked items and bandages to clean and bandage wounds, since they healed minimal amounts).

@Mecares I know quite well the difference between just cleaning a wound with disinfectant to prevent an infection from setting in in the first place, and treating a surface infection. There isn't much of one. Infection doesn't just immediately spread throughout your body, delving deep into your tissues and getting into your bones; not without some massive, serious damage, and absolutely no treatment done. Lancing inflamed, infected tissues to open abscesses, cleaning the wound with sterile water (simple boiled water suffices, but a saline solution is better, as I've already noted) and/or a disinfectant and/or applying topical antibiotics/antiseptics can halt the spread and start regression of a surface infection. This is common practice, in fact, for wound-based infections. Oral antibiotics are overprescribed and not needed for every single infection. Deep tissue infection is an entirely other matter, but you don't get deep tissue infection from surface wounds; not without letting a wound fester for days before even attempting initial treatment, anyways, at which point you're basically delirious and soon to die (just as what happens with an infection left to spread and a low health value that allows it to run roughshod over your body right now anyways). Infections are just a critical mass of bacteria or viruses that are causing a negative reaction in your body. Disinfectants work by damaging the proteins that those bacteria and viruses need to "live" and/or replicate. They don't suddenly become useless because there's more of them.

@Xhuis I disagree, here, actually. Infections shouldn't be made less threatening to your healt; without antibiotics/antiseptics/antibacterials/antimicrobials etc, they're actually a pretty serious danger to daily life, especially in a world where humanity is no longer the apex predator species. However, it's also not as hard as they're trying to make it to cleanse a wound or take care of an infection, either, which is where the problem lies.