Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds pet FOOD flag for monsters and taming #23779
Conversation
This comment has been minimized.
This comment has been minimized.
|
Need document added for modder |
This comment has been minimized.
This comment has been minimized.
I don't understand what you're asking. |
This comment has been minimized.
This comment has been minimized.
I think they mean you should add a brief explanation of what the flag does in /doc/JSON_FLAGS.md |
This comment has been minimized.
This comment has been minimized.
Yeah, not sure why when there's plenty of stuff not documented... milkable isn't even there. Either way, this has been corrected. |
This comment has been minimized.
This comment has been minimized.
Gee, I wonder how that became problem in the first place... |
This comment has been minimized.
This comment has been minimized.
|
There are three pet food types. Can you expand this further for all three types? |
This comment has been minimized.
This comment has been minimized.
|
@smolbird chill it with the snide comments, if you dont have anything productive to say, you dont have anything to say. |
This comment has been minimized.
This comment has been minimized.
You mean dog food, cat food, and cattle fodder? The only one missing is cat food. I suppose I can replace that as well. Please specify so I can address this sooner. Thank you.
This is my fault. I wasn't being reasonable, because I thought I had explained what it did in mtype.h, but I realize I should be documenting in the DOC files as well, to hopefully assist others like myself, trying to help create with little to no knowledge of coding changes. |
This comment has been minimized.
This comment has been minimized.
|
Added new flag to mon_dog to retain ability to tame them. Rather than making a new PR to fix that if this one is merged. A "Duh!" moment for me. |
This comment has been minimized.
This comment has been minimized.
Yes, cat food. You can do it in another PR if you want to. |
DracoGriffin
changed the title
Adds DOGFOOD flag for monsters and taming
Adds pet FOOD flag for monsters and taming
May 21, 2018
This comment has been minimized.
This comment has been minimized.
Might as well address it now, it's not like it's two wholly separate things -- pretty related. Either way, this has been fixed. |
DracoGriffin commentedMay 20, 2018
•
edited
Creatures with CATFOOD / DOGFOOD flag can be tamed when fed with cat / dog food, respectively.
Simple PR to allow for upcoming expanded dog breeds and more.