Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDog Whistle Affects More Dogs #23794
Conversation
ZhilkinSerg
added
Monsters
[C++]
labels
May 21, 2018
This comment has been minimized.
This comment has been minimized.
|
Jenkins rebuild. |
ZhilkinSerg
merged commit e8166a0
into
CleverRaven:master
May 21, 2018
DracoGriffin
deleted the
DracoGriffin:dogwhistle_moretargets
branch
May 21, 2018
This comment has been minimized.
This comment has been minimized.
|
Also check hearing senses of a critter? |
This comment has been minimized.
This comment has been minimized.
I only adjusted to match the dog food code for upcoming PR. This is probably something that should be developed further (hearing check) but I'm not sure if critters (as in tamed dogs in this example) can be deafened. If so, then it'd be worth looking into (I have basically no knowledge regarding dog whistles and hearing with dogs -- and how it affects them if deaf/hearing impaired). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
DracoGriffin commentedMay 21, 2018
Dog whistle will now affect creatures with DOGFOOD flag rather than a single creature.
Simple PR to allow for upcoming expanded dog breeds and more.