Fixed spawning fresh food instead of spoiled after passing long time

[Firestorm01X2]

Fix to:
#22308
Players may notice that some time after passing even year they may be able to find fresh food in houses.
It was bug. Food creation date was set to "discovered" turn instead of start of the apocalypse in some cases.

#22308 (comment)

Some mapgen code uses calendar::turn as birthday of spawned items (for example jmapgen_liquid_item or jmapgen_loot). Those items are created at the current turn and are therefor considered fresh. Mapgen should create items with birthday calendar::time_of_cataclysm.

Note that the default for new items is the current turn, but the default for items created via map::spawn_item and similar is time_of_cataclysm. Also: mapgen should have a turn parameter that dictates which turn to use as birthday, but it's not forwarded correctly all the time.

Fix is simple: corrected item birthday to correct date - time of apocalypse.

For now it was done for:

jmapgen_loot
jmapgen_liquid_item
vehicle::place_spawn_items

I hope that is enough for fixing food.

[Firestorm01X2]

Also I don't undertstaind - is there really any reason to set to birthday during mapgen to something different than calendar::time_of_cataclysm?

[ZhilkinSerg]

Also I don't undertstaind - is there really any reson to set to birthday during mapgen something different from calendar::time_of_cataclysm?

I would say it should be jsonized with default value set to calendar::time_of_cataclysm. Different values could be used for NPC-infested facilities (e.g. bandit camps).

[Firestorm01X2]

Ok. I've tested it. Now I can't find non canned fresh food in houses in "Next Summer" scenario. Fix itself is pretty simple.

Ready fo review.

[Firestorm01X2]

I would say it should be jsonized with default value set to calendar::time_of_cataclysm. Different values could be used for NPC-infested facilities (e.g. bandit camps).

Probably. But as bugfix it should be good enough for now.

[ZhilkinSerg]

Probably. But as bugfix it should be good enough for now.

Agree.