Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTest and fix zapback #23968
Conversation
kevingranade
added some commits
Jun 1, 2018
kevingranade
force-pushed the
kevingranade:test-and-fix-zapback
branch
to
9dce3d4
Jun 7, 2018
Night-Pryanik
reviewed
Jun 7, 2018
| TEST_CASE( "zapback_npc_nonconductive_unarmed_weapon", "[mondefense]" ) | ||
| { | ||
| standard_npc attacker( "Attacker" ); | ||
| // AFAICT this is the only nonconductive unarmed weapon. |
This comment has been minimized.
This comment has been minimized.
Night-Pryanik
reviewed
Jun 7, 2018
| TEST_CASE( "zapback_npc_nonconductive_unarmed_weapon", "[mondefense]" ) | ||
| { | ||
| standard_npc attacker( "Attacker" ); | ||
| // AFAICT this is the only nonconductive unarmed weapon. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Where NPC hp were set before db742a6? |
This comment has been minimized.
This comment has been minimized.
|
This is a separate npc constructor used for making testing npcs. I want actually able to pin down where it happens normally, for players it happens in newcharacter.cpp |
DracoGriffin
added
the
<Bugfix>
label
Jun 11, 2018
ZhilkinSerg
assigned
ZhilkinSerg
and unassigned
ZhilkinSerg
Jun 13, 2018
ZhilkinSerg
merged commit bea2a7e
into
CleverRaven:master
Jun 13, 2018
kevingranade
deleted the
kevingranade:test-and-fix-zapback
branch
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevingranade commentedJun 7, 2018
As mentioned here, zapback was triggering in an obscure case where a ranged weapon also had a reach attack.
While investigating I also discovered that said weapons had no way of triggering the reach attack, so I added automatic inserion of an appropriate firing mode to items of this kind on creation and fixed fire action handling.