FRAGILE_MELEE, continued. #24028

NotFuji · Jun 16, 2018

Continues the feature added in #23963

FRAGILE_MELEE now checks for the weakest component used to make the item for use in damage calculations. Crafting components now directly impact the durability of said weapons
Items commonly used as "handle wrappings" such as rags and leather are omitted.
Additional skill/stat modifiers are now correctly applied
Fragile items are given a further 6x bonus increase to damage chance to compensate for the apparently over-strong materials that are often weakpoints. ( Cotton, more specifically. If cotton were to have it's chip_resistance lowered to 1 from 6, function would be nearly identical as no bonus chance. ) Overall, items like the knife spear break approximately half as often as they do in mainline.
Upon breaking a fragile item has a chance to drop it's crafting components. Handles (the largest component by volume) are retained by the player, and the weakest item has a higher chance of being destroyed. Closes #24018
For fragile items with no specified crafting components, such as those naturally spawned into the world, damage chance is 6x the default value. Items are simply destroyed when broken. ( This should rarely happen if ever, FRAGILE_MELEE is meant for shoddy player-made weapons )

Firestorm01X2 · Jun 16, 2018

I suggest to think about possibility to use some of new behavoir by default.

0be1isk · Jun 16, 2018

NOW THIS IS WHAT I'M TALKING ABOUT.
This is an example of a not so half baked spiteful idea.

Lorith · Jun 16, 2018

I'll have to see how it works out ingame, but this seems like a far better solution, and should be able to work in many cases equally well.

Xhuis · Jun 16, 2018

I think FRAGILE_MELEE was originally written in a quick-and-dirty way as part of an attempted nerf against knife spears, just like that other PR. Up until now, the flag has been lacking and very niche. This makes the flag more useful and should hopefully encourage additions with it that don't have to explicitly state they're not trying to nerf something.

0be1isk · Jun 16, 2018

I tried playing with the half baked tag AlienZimogor hastly PRed, and the durability of the knife spear is on par with the extremely absurd weapon durability in BOTW, so I removed it from my JSON folder.
Because no one seemingly wants to/or it seems cares about the consistency, I'm working on a PR that applies the tag to most if not all "items" in the game that makes sense. For example, you can use a glass bottle or bowl as a weapon, however irl, if you were to do so, it would break instantly. This fragile tag would work well for those items.

victorsegall · Jun 16, 2018

Quite sensible that a component is damaged and therefore is the part referenced for damage to cause the break. This will also support variant recipes that use more or improved materials. As-is it supports the fact that existing recipes have variable ingredients that can represent consequential choices.

Reading thread for the PR #23963 shows its author being consistent (FRAGILE_MELEE because we already have DURABLE_MELEE) rather than opinionated like #24005 which simply uses the flag before it's ready to be used. #23963 was only using knife spear as an obvious example, which it is. The flag is appropriate and this PR improves it. #24018 will also improve it. It needs to be improved, as @kevingranade and others are clearly guiding @AlienZimogor to force the work to get done.

Set Zimogor's misguided motivations and language aside, because we'll have to. Could mod it out, but shouldn't be forced to.

Without looking, I'd take the bet that DURABLE_MELEE hasn't received this level of attention. It should.

DracoGriffin · Jun 16, 2018

Looks much more well-thought out and put together. Extremely well done, Fuji.

Like victor suggested, is DURABLE_MELEE in a suitable place or would it also benefit from some of your treatment, Fuji?

NotFuji · Jun 16, 2018

DURABLE_MELEE probably works just find as-is. There's not much that can be done to make it more interesting without completely changing how item damage works.

Coolthulhu · Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu · Jun 17, 2018

src/melee.cpp

+        int weak_chip = INT_MAX;
+
+        // Items that should have no bearing on durability
+        const std::vector<itype_id> blacklist = { "rag",


You want a std::set here. Then check it with blacklist.count( type_here ) > 0.

Coolthulhu · Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu · Jun 17, 2018

src/melee.cpp

+                                                  "leather",
+                                                  "fur" };
+
+        std::vector<item> valid_components;


No need to make copies of the components. You can iterate over components themselves while they're still components - you don't alter them here and only take the type and chip resistance.

Coolthulhu · Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu · Jun 17, 2018

src/melee.cpp

+                                      _( "<npcname>'s %s breaks apart!" ),
+                                      str.c_str() );
+
+        std::vector<item> all_comps = temp.components;


No need to copy the component vector here. Just iterate over the components themselves.
If you need to make a copy (for example, before wielding), it's better to explicitly copy it there.

Coolthulhu · Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu · Jun 17, 2018

src/melee.cpp

+        std::vector<item> all_comps = temp.components;
+
+        for( auto &comp : all_comps ) {
+            int break_chance = comp.typeId() == weak_comp ? 2 : 8;


I'm not sure what you're doing here.
weak_comp is the item with the highest chip_resistance. Why does this specific item get 4 times lower chance at avoiding destruction?

You have that backwards. weak_comp has the lowest chip resistance, and so is considered the "breaking point" of the weapon and has a lower chance of being recovered when the weapon falls apart.

Coolthulhu · Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu · Jun 17, 2018

src/melee.cpp

+                continue;
+            }
+
+            if( comp.has_flag( "HANDLE" ) && !is_armed() ) {


Rather than explicit HANDLE flag, which would require a lot of marking, you could default to the largest item.
It would be correct in majority of cases and the minority could be special cased.

BorkBorkGoesTheCode · Jun 27, 2018

ETA? (I'm going to stop asking because it might be annoying)

ZhilkinSerg · Jun 27, 2018

I've already broken 5 knife spears, but no components appeared yet.

ZhilkinSerg · Jun 27, 2018

I've already broken 5 knife spears, but no components appeared yet.

My bad. That only applies to debug spawned items - apparently they aren't crafted and have no components. Hand crafted spears are shattered fine.

Xhuis · Jun 27, 2018

Yay! This makes it a compromise that's a lot less frustrating. Thank you!

NotFuji added some commits Jun 16, 2018

Re-implementation of FRAGILE_MELEE

6f4b08e

Adjusted fragility

896d4e0

Component breakdown for FRAGILE_MELEE

02fb8c6

Removed debug stuff

1abe958

Breakable handles

Loading status checks…

d2a1e03

victorsegall referenced this pull request Jun 16, 2018
Merged
Time to use FRAGILE_MELEE: round two, SPEAR_FORKED #24014

ZhilkinSerg added Game: Balance [JSON] [C++] Melee labels Jun 16, 2018

Removed more debug stuff

Loading status checks…

f70cc39

Requested Changes
- Simplified blacklist with std::set. - Removed unnecessary copying of component list. - Replaced "HANDLE" flag with check for largest component by volume.

Loading status checks…

3c1c311

ZhilkinSerg self-assigned this Jun 27, 2018

ZhilkinSerg merged commit 3e28411 into CleverRaven:master Jun 27, 2018
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

coverage/coveralls Coverage increased (+0.02%) to 23.812%
Details

gorgon-ghprb Build finished.
Details

ZhilkinSerg removed their assignment Jun 27, 2018

CleverRaven/Cataclysm-DDA

Join GitHub today

FRAGILE_MELEE, continued. #24028

Conversation

NotFuji commented Jun 16, 2018 • edited

NotFuji added some commits Jun 16, 2018

This comment has been minimized.

Firestorm01X2 commented Jun 16, 2018

This comment has been minimized.

0be1isk commented Jun 16, 2018 • edited

This comment has been minimized.

Lorith commented Jun 16, 2018

This comment has been minimized.

Xhuis commented Jun 16, 2018

This comment has been minimized.

0be1isk commented Jun 16, 2018 • edited

This comment has been minimized.

victorsegall commented Jun 16, 2018 • edited

victorsegall referenced this pull request Jun 16, 2018

Time to use FRAGILE_MELEE: round two, SPEAR_FORKED #24014

ZhilkinSerg added Game: Balance [JSON] [C++] Melee labels Jun 16, 2018

This comment has been minimized.

DracoGriffin commented Jun 16, 2018

This comment has been minimized.

NotFuji commented Jun 16, 2018

Coolthulhu reviewed Jun 17, 2018 View changes

This comment has been minimized.

Coolthulhu Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018 View changes

This comment has been minimized.

Coolthulhu Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018 View changes

This comment has been minimized.

Coolthulhu Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018 View changes

This comment has been minimized.

Coolthulhu Jun 17, 2018

This comment has been minimized.

NotFuji Jun 17, 2018

Coolthulhu reviewed Jun 17, 2018 View changes

This comment has been minimized.

Coolthulhu Jun 17, 2018

This comment has been minimized.

BorkBorkGoesTheCode commented Jun 27, 2018 • edited

ZhilkinSerg self-assigned this Jun 27, 2018

This comment has been minimized.

ZhilkinSerg commented Jun 27, 2018

This comment has been minimized.

ZhilkinSerg commented Jun 27, 2018

Hide details View details ZhilkinSerg merged commit 3e28411 into CleverRaven:master Jun 27, 2018 3 checks passed

3 checks passed

ZhilkinSerg removed their assignment Jun 27, 2018

This comment has been minimized.

Xhuis commented Jun 27, 2018

NotFuji commented Jun 16, 2018 •

edited

0be1isk commented Jun 16, 2018 •

edited

0be1isk commented Jun 16, 2018 •

edited

victorsegall commented Jun 16, 2018 •

edited

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu reviewed Jun 17, 2018

View changes

Coolthulhu reviewed Jun 17, 2018

View changes

BorkBorkGoesTheCode commented Jun 27, 2018 •

edited

ZhilkinSerg merged commit `3e28411` into CleverRaven:master Jun 27, 2018
3 checks passed