Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMore sensible anesthesia (though still abstracted) when using autodoc #24062
Conversation
Night-Pryanik
added some commits
Jun 21, 2018
Night-Pryanik
added
<Enhancement / Feature>
[JSON]
Bionics
[C++]
Effects / Skills / Stats
labels
Jun 21, 2018
ZhilkinSerg
self-assigned this
Jun 22, 2018
ZhilkinSerg
merged commit 23f6879
into
CleverRaven:master
Jun 22, 2018
ZhilkinSerg
removed their assignment
Jun 22, 2018
Night-Pryanik
deleted the
Night-Pryanik:autodoc-updates-part3
branch
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Night-Pryanik commentedJun 21, 2018
It seems that sending character to narcosis while using autodoc through the simple
fall_asleepfunction isn't enough. Character can wake up prematurely due to too many factors. Now, with the newly addednarcosiseffect type, character won't react and wake up on almost any stimulus.Probably the most important change of this PR is that under narcosis character won't react on any type of damage until the end of installation/uninstallation of bionics, so it is easy to get eaten by a single wandering zombie that come to look at autodoc making operation.