Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodoc now requires an actual anesthesia to work #24071

Merged
merged 14 commits into from Jun 23, 2018

Conversation

Projects
None yet
5 participants
@Night-Pryanik
Copy link
Member

commented Jun 23, 2018

  • Added an anesthesia kit item with an ANESTHESIA flag;
  • Made it spawn in bionic basement (guaranteed), doctor's office (high chance), hospital and veterinarian office (both have average chance);
  • Autodoc will check for items with aforementioned flag in player's inventory and his surroundings. If valid item is found, it will be consumed on operation (both install and uninstall of bionics). One kit per operation no matter the duration or difficulty;
  • Removed painkiller threshold that was needed to achieve prior to installation of bionics;
  • Removed the need of a tool with fine cutting quality and a first aid kit to uninstall bionics;
  • Player can use any items with aforementioned flag (though it's only one in vanilla for now) for operations;
  • Added description for the flag in JSON_FLAGS.md.
@John-Candlebury

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

Please check a flag and not only the direct Id of the anesthesia item, to make this feature moddable

@nexusmrsep

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

Just an idea: with high first aid skill, using few empty syringes, a meter of duct tape, and right ammount of specific drugs and/or painkillers player might be able to make a makeshift anesthesia kit as an option, when not being able to find a real one. I can drop a PR for this if it fits this theme?

Night-Pryanik added some commits Jun 23, 2018

Added new ANESTHESIA flag to the anesthesia kit
Also added description for the said flag to JSON_FLAGS.md
Replaced check for anesthesia from hardcoded id to items with ANESTHE…
…SIA flag

Also make consume_items consume an item with the flag instead of hardcoded id
@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2018

Please check a flag and not only the direct Id of the anesthesia item, to make this feature moddable

Done.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2018

Just an idea: with high first aid skill, using few empty syringes, a meter of duct tape, and right ammount of specific drugs and/or painkillers player might be able to make a makeshift anesthesia kit as an option, when not being able to find a real one. I can drop a PR for this if it fits this theme?

I'm not against it. Just wait when/if this PR get merged, and describe in details which drugs you are planning to use in the recipe.

@John-Candlebury

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

Please check a flag and not only the direct Id of the anesthesia item, to make this feature moddable

Done.

Thank you!

@Xhuis

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

Do you plan to remove manual installation of CBMs? I'm not sure how I feel about that idea in particular, but if it stays, it does seem like a good choice to make the Autodoc preferred. Maybe the success chance is increased for the Autodoc, it takes less time, or something along those lines. Making manual installations take time would also not be a bad idea, as right now you can install eight bionics within the space of one turn since it doesn't pass time.

Oh, and since this deprecates the worldmod that removes needing painkillers for bionics, it might not be a bad idea to remove that, or if you're going to remove manual installation, to change it into "easy bionic installation" or something like that that preserves the old way.

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2018

Do you plan to remove manual installation of CBMs?

Yes, I do.

the worldmod that removes needing painkillers for bionics

This mod is not in vanilla, it's in @Coolthulhu's fork.

or if you're going to remove manual installation, to change it into "easy bionic installation" or something like that that preserves the old way.

I'm not interested in making "old-style bionic installation" mod myself, but I'm not against if someone will implement it.

Extracted function of introducing patient into anesthesia and refacto…
…red processes of (un)installing bionics
@Xhuis

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

Mmk, fair enough.

@ZhilkinSerg ZhilkinSerg merged commit e265179 into CleverRaven:master Jun 23, 2018

2 of 3 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gorgon-ghprb Build finished.
Details

@Night-Pryanik Night-Pryanik deleted the Night-Pryanik:autodoc-updates-part4 branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.