[RDY]Automatic fire refuelling

[Coolthulhu]

Long requested feature that got more urgent ~recently, because I implemented a mechanic that makes dying fires more annoying.

Use case goes like this:

• Player has a small fire adjacent
• Player has a pile of burnable items - wood pile - adjacent on ONE spot (went for simplicity, the PR grew big fast)
• Player marks the wood pile using construction menu. Kinda ugly, but I had no better idea that wouldn't get huge fast. It will be easy to change that in the future, though.
• Player starts a long action that requires light (manually marked in json) - reading or crafting
• The fire ages to 10 minutes or so
• The character automatically moves enough items from wood pile to fire pile to keep the fire going. Items on top of the wood pile are picked first, liquids are skipped, unburnable items are skipped.
• Time passes
• The fire gets too big because of low granularity of fuel items
• The character moves first flammable, non-liquid item from fire pile to wood pile, to slow down the rate of burning

I successfully tested it in the following cases:

• Reading adjacent to a free-standing fire. The fire didn't explode and didn't go out.
• Reading adjacent to fireplace. The fireplace wasn't over-fueled and it went out shortly after.
• Reading adjacent to over-fueled free-standing fire. The fire was quickly un-fueled and didn't go super-critical (ie. stayed at intensity 1).

Additionally:

• Made fire burning more deterministically. It got too chaotic and the player can't easily see if the fire is about to turn into a fireball or go out. May break compatibility with some mods that used burn_data::chance_in_volume.
• Made fire code use units::volume instead of legacy cups

[CR] because my C++ may be a bit rusty, and because of that weird designation thing.

[RadHazard]

Does this work with crafting that requires fire (e.g. cooking)? I know that it currently doesn't interrupt crafting if the fire goes out halfway through, but if this system works then it seems like it would be reasonable to change it so that it does.

[Coolthulhu]

Does this work with crafting that requires fire (e.g. cooking)?

Currently all crafting triggers it, even if you don't need the light because you have other sources.

[OzoneH3]

Works great. Maybe up the fire/stockpile range from adjacent to crafting range?

[Coolthulhu]

Maybe up the fire/stockpile range from adjacent to crafting range?

Yeah, would be better than hardcoded 1 range limit.

@kevingranade any objections? The closest analogy I recall would be the vehicle crane thing, which is limited to 1 tile.

[kevingranade]

If the player is free to move during the activity, then using crafting range is reasonable. I also don't anticipate perf issues for scanning since it only happens intermittently during crafting.

[Coolthulhu]

Does "Jenkins, rebuild" re-trigger Travis too?

[kevingranade]

It does not, you may be able to visit the travis page and restart the failing build(s), but I'm unclear on permissions for that.

[Coolthulhu]

Nope. Requires developer privs

[Night-Pryanik]

I was able to restart this travis build.

[ZhilkinSerg]

du -> due

[ZhilkinSerg]

I cannot do thorough testing right now, but works fine at first glance.

[kevingranade]

I've merged this and tested it locally, but I seem to have forgotten the push it, so feel free to just resolve the conflict in item.h and push it.

[kevingranade]

I've merged this and tested it locally, but I seem to have forgotten the push it, so feel free to just resolve the conflict in item.h and push it.

[kevingranade]

This should find the best contained fire, instead it finds the first contained fire, I'm fine to leave it as a bugfix.

[Coolthulhu]

I forgot to change it after the range increase, though it's next to trivial.
I'll leave it as is for now since it's tested already. It's pretty unlikely that a player will have two contained fires anyway.

[Coolthulhu]

I'm not authorized because I'm not a part of CleverRaven at the moment.
If you add me, I'll push the fix.

[Brambor]

Does not work with charcoal. Maybe it has something to do with that charcoal stacks in form charcoal (50) whereas two-by-four and more flamable items stack in two-by-four 50x.

I would expect charcoal to be valid item for keeping the fire going.

[Brambor]

Oh and it is not clear how to stop refueling the fire as if you read by the window and the PC keeps throwing more and more wood into the fire.