Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhancement to calendar in Lua #24140
Conversation
ZhilkinSerg
added some commits
Jun 30, 2018
ZhilkinSerg
added
<Enhancement / Feature>
Mods
[C++]
[Lua]
<Bugfix>
labels
Jun 30, 2018
ZhilkinSerg
added some commits
Jul 4, 2018
ZhilkinSerg
merged commit 92408c0
into
CleverRaven:master
Jul 4, 2018
ZhilkinSerg
deleted the
ZhilkinSerg:lua-calendar
branch
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ZhilkinSerg commentedJun 30, 2018
•
edited
What was changed:
get_turnfunction incalendarclass in Lua (returns current turn number) - fixes #24126 (minor regression introduced in #22583);calendarclass in Lua;get_time_durationfunction to Lua for easier creation oftime_durationvia wrapper functions (TURNS,MINUTES,HOURSandDAYS);time_pointandtime_durationclasses in Lua;calendarcode.