Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[READY?!?!?] Fragmentation overhaul #24171
Conversation
kevingranade
force-pushed the
kevingranade:fragmentation-overhaul
branch
Jul 3, 2018
ZhilkinSerg
reviewed
Jul 3, 2018
| continue; | ||
| } | ||
|
|
||
| if( v.v->obstacle_at_part( part ) >= 0 ) { |
This comment has been minimized.
This comment has been minimized.
ZhilkinSerg
Jul 3, 2018
•
Contributor
Will need changes due to #23873. Something like:
if( vpart_position( *v.v, part ).obstacle_at_part() ) {
This comment has been minimized.
This comment has been minimized.
|
Lol, I've just blasted a prison, a hospital and a football field with a mininuke and that was something! |
ZhilkinSerg
added
<Enhancement / Feature>
[JSON]
[C++]
labels
Jul 3, 2018
kevingranade
force-pushed the
kevingranade:fragmentation-overhaul
branch
2 times, most recently
Jul 4, 2018
kevingranade
force-pushed the
kevingranade:fragmentation-overhaul
branch
Jul 27, 2018
kevingranade
changed the title
Fragmentation overhaul
[READY?!?!?] Fragmentation overhaul
Jul 27, 2018
This comment has been minimized.
This comment has been minimized.
|
That might be an incentive for a new set of home made explosive traps/mines. |
DracoGriffin
referenced this pull request
Jul 27, 2018
Closed
Feedback / Next Steps on Lab Expansion #24508
This comment has been minimized.
This comment has been minimized.
|
Need to consider ranges.
|
This comment has been minimized.
This comment has been minimized.
|
Probably for a different PR, but fuses which the player is able to lay on the ground would be cool, allowing a remote detonation. |
This comment has been minimized.
This comment has been minimized.
That was originally a big thing I wanted to add, but this whole thing took waaaaay too long. |
ZhilkinSerg
added
the
(P2 - High)
label
Jul 29, 2018
This comment has been minimized.
This comment has been minimized.
Couldn't heavy duty cable code be used for this? |
This was referenced Jul 30, 2018
This comment has been minimized.
This comment has been minimized.
This is actually a lot simpler than what vehicle power cables do, so I'd prefer to not tie those two together. Opened another issue for fuses: #24556 |
kevingranade
added some commits
Dec 19, 2017
kevingranade
force-pushed the
kevingranade:fragmentation-overhaul
branch
to
2fbac5b
Aug 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Tweaked throw distances (but not accuracy) to make grenades usable without killing yourself. |
This comment has been minimized.
This comment has been minimized.
|
Fuse times of large charges adjusted so you have time to get clear. Should be good to go unless something bad crops up. |
kevingranade commentedJul 3, 2018
•
edited
What a haul, this took many times longer than expected, but it's ready for checking out, I've exhausted the issues I know about.
Main features:
Specifically, added tests to verify that M87 is highly lethal at 5m, and drops sharply in lethality at 15m.
Interacts with obstacles, including monsters, leading to fragmentation effectiveness scaling nicely based on openness of terrain.
Some discussion of the changes on the forums.
Some RDX charge tests:
https://discourse-cdn-sjc2.com/standard15/uploads/cataclysmdda/original/2X/3/381595cec2e35e0985f9204c500bad19806ea9b3.png
https://discourse-cdn-sjc2.com/standard15/uploads/cataclysmdda/original/2X/1/171351ccca9b12d8136c2dca503232a504a2a916.png