Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMutagen and mutation cleanup #24183
Conversation
Kelenius
added some commits
Apr 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Should be ready. |
ZhilkinSerg
assigned
ZhilkinSerg
and unassigned
ZhilkinSerg
Jul 8, 2018
This comment has been minimized.
This comment has been minimized.
|
Any problems here? |
This comment has been minimized.
This comment has been minimized.
Nope, just need more spare time to merge test this. |
ZhilkinSerg
added
the
(P2 - High)
label
Jul 29, 2018
This comment has been minimized.
This comment has been minimized.
|
I guess it is safe to remove following lines now: Cataclysm-DDA/doc/JSON_FLAGS.md Lines 807 to 829 in 8badff7 |
This comment has been minimized.
This comment has been minimized.
|
Looks good in fresh world with new character. |
Kelenius
added some commits
Jul 30, 2018
ZhilkinSerg
merged commit 9da0b35
into
CleverRaven:master
Aug 1, 2018
Kelenius
deleted the
Kelenius:MutationCleanup
branch
Aug 1, 2018
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Kelenius commentedJul 3, 2018
•
edited by ZhilkinSerg
#23519
Removed defaults from
threshold_mut,mutagen_message,iv_message. Mutation categories MUST set them.Proper spacing around ellipses in mutagen messages and dreams.
Changed IV yelling messages to make more sense.
Changed how mutagen category is retrieved from the mutagen - now it uses
properties. Because of that, the abstracts were changed - the game currently can't using copy-from on something that has properties/qualities set, then setting it in the child too. There's no property for ANY, because that's the default state now.Cleaned up categories. Previously:
id: "mutation_plant"
category: "PLANT"
category_full: "MUTCAT_PLANT"
mutagen_flag: "MUTAGEN_PLANT"
Now:
id: "PLANT"
That's it. The rest is redundant.
Cleaned up mutagen iuse.
Removed MUTAGEN_STRONG flag from mutagen serum. It has no effect; the amount of mutations gained from serums is adjustable in the category JSON.