Skip to content

/Cataclysm-DDA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe vehicle parts Part 1a #24281

Merged
merged 5 commits into from Jul 14, 2018

Conversation

Reviewers

@RadHazard RadHazard

Assignees
No one assigned
Labels
Translation Vehicles [JSON]
Projects
  
Done in Extended Vehicle Tune-Up
Milestone
No milestone
4 participants
@mlangsdorf @Night-Pryanik @RadHazard @ZhilkinSerg
@mlangsdorf
Copy link
Contributor

commented Jul 12, 2018

Part 1a in a multi-step process to enhance the vehicle construction menu, similar to "Construction Menu UI enhancements #24105".

Add descriptions for all the vehicle parts. The descriptions are intended to be functional and give some indication of why you would want to install a particular part and sometimes where you would to install it.

Part 1b will add similar descriptions to the Blazemod parts.

Parts 2+ will change the vehicle interaction screen to display the descriptions, along with some of the other data from the JSON. I'd like to at least expose epower and LIFT and JACK qualities if I can. I definitely want to indicate the location field.

I expect the descriptions will generate some discussion, so I want to get them accepted before I move on.

mlangsdorf added some commits Jul 12, 2018

@mlangsdorf
vehicle parts: add descriptions for the parts 
Add descriptions for the vehicle parts, as they are installed on the
vehicle, instead of as vehicle components.

A future commit will display this description in the vehicle
interaction screen.
8342429
@mlangsdorf
vehicle parts: astyle the vehicleparts directory 
minor cleanups before adding descriptions
0dfa215
@mlangsdorf
vehicle parts: add descriptions to vehicleparts directory 
Add descriptions for the vehicle parts, as they are installed on the
vehicle, instead of as vehicle components.

A future commit will display this description in the vehicle
interaction screen.
Loading status checks…
a317e6b
@Night-Pryanik

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 12, 2018

Some of the vehicle parts are just variants of each other, like handle or wooden handle, so their description is identical. I wonder if adding them some flag and then describing this flag in flags.json would be a cleaner solution? Though this of course means much more work than simple filling the description field.
@mlangsdorf

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 12, 2018

That's a good suggestion.
What I would prefer to do is get the text of descriptions worked out in this PR.
A future PR will add displaying the descriptions and parsing the flags.
After that PR is complete, then I would be ready to refactor the common text into flags in another PR.
@Night-Pryanik

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 12, 2018

Ok then. The one last thing I want to mention is two spaces after periods inside the sentences.
@RadHazard

RadHazard reviewed Jul 12, 2018
View changes

data/json/vehicleparts/boards.json Outdated
@@ -28,6 +30,7 @@
"copy-from": "clothboard",
"type": "vehicle_part",
"name": "cloth quarterpanel",
"description": "A half-height cloth wall. Keeps zombies outside the vehiclebut allows people to see over it.",

This comment has been minimized.

Sign in to view
Copy link
@RadHazard

RadHazard Jul 12, 2018

Contributor

Missing a space here

This comment has been minimized.

Sign in to view
Copy link
@mlangsdorf

mlangsdorf Jul 13, 2018

Author Contributor

Fixed.

This comment has been minimized.

Sign in to view
Copy link
@RadHazard

RadHazard Jul 13, 2018

Contributor

You fixed the double spacing, but I was actually talking about the typo ("vehiclebut"). I probably should have clarified after Night-Pryanik's comment. Looks like the same typo got copy-pasta'd several times as well, including a few I missed last night
data/json/vehicleparts/boards.json Outdated
@@ -36,6 +39,7 @@
"copy-from": "board",
"type": "vehicle_part",
"name": "quarterpanel",
"description": "A half-height metal wall. Keeps zombies outside the vehiclebut allows people to see over it.",

This comment has been minimized.

Sign in to view
Copy link
@RadHazard

RadHazard Jul 12, 2018

Contributor

Same here

This comment has been minimized.

Sign in to view
Copy link
@mlangsdorf

mlangsdorf Jul 13, 2018

Author Contributor

Fixed.

@ZhilkinSerg ZhilkinSerg added Translation [JSON] Vehicles labels Jul 12, 2018

@mlangsdorf

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 13, 2018

Spaces added, as per the style manual.

@ZhilkinSerg ZhilkinSerg merged commit 340fb96 into CleverRaven:master Jul 14, 2018
4 checks passed

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 23.431%
Details
gorgon-ghprb Build finished.
Details
@mlangsdorf

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 16, 2018

part 2: #24328

@mlangsdorf mlangsdorf deleted the mlangsdorf:describe_vehicle_parts branch Jul 23, 2018

@mlangsdorf

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 24, 2018

Better descriptions for some parts, display descriptions for installed parts #24462

@mlangsdorf mlangsdorf added this to Done in Extended Vehicle Tune-Up Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.