Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electric motor size revamp : Add tiny motor and micro motor #24329

Closed
wants to merge 22 commits into from

Conversation

Projects
None yet
9 participants
@Fris0uman
Copy link
Contributor

commented Jul 16, 2018

Add a new smaller type of electric motor : the tiny motor, a 0.5HP (power : 4) electric motor.

Replace motor_small with motor_tiny in several recipes : door_motor, drive_by_wire_controls, carver_off, cordless_drill, food_processor, makeshift_sealer and electric_hair_trimmer.

Add motor_small to deconstruction recipe of dryer and whashing machine.

Idea comes from this discussion : washing-machine-and-dryer-not-containing-a-motor

There's still at least two issue that i can see but don't know how to resolve :

  • I couldn't get the volume to be smaller than 1 (without being 0)
  • tiny motor might be a silly and imprecise name, maybe it'd be good to rename electric motors with a better convention ? Using HP or Voltage, I don't know how it works in real life.
@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

I couldn't get the volume to be smaller than 1 (without being 0)

Your motor appears to be less than 250 ml (= 1 volume)?

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

Also fan item could probably yield this motor on disassemble?

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2018

Your motor appears to be less than 250 ml (= 1 volume)?

Yes it's the same size as the small motor, which kind of defeat the purpose of making a "smaller" motor.
But if I input a value between 1 and 0 the item is automatically 0.01L

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

Then I feel the small motor volume should be increased. And probably ordinary motor too. A powerful electric motor with a volume of only 1,5 liters?

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2018

Yep there's something weird with the sizes of motors.
But I need to do some more research to understand what should be their real size

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

A powerful electric motor with a volume of only 1,5 liters?

Electric motors don't have to be very large to be really powerful. Car starters are an example.

@sfsworms

This comment has been minimized.

Copy link

commented Jul 17, 2018

I was a bit interested in trying to correct the various motor power output, weight and size (to prevent tanks doing 300 mph among other issues). I'll try to dig up some numbers at some point.

@Mecares

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2018

Half a horsepower is still a lot of power, we are talking about 370 Watts. Maybe power 1 would be better than 4 for most uses of a tiny motor. We could think about adding it to all manhack and turret recipes. Maybe add some tiny motors to the butchering results of robots.

Half a horsepower would be a good size for a E-Bike Motor, a quick google search shows most of them at 250 Watt of engine power. With a weight of around 3-4 kg.
(Source in German i apologize: https://www.emotion-technologies.de/e-bike-infos/e-bike-pedelec-antriebe/)

Electro Mopeds seem to have around 800-1200 Watt of engine power, 1 Hp to 1,5

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2018

So looking through this catalogue : (Europe) StandardCatalogue p7, 12 and 13.
I find that a 10 HP electric motor (motor_small) would weight at least 72.5kg and have a volume of 25L (I calculated the volume as if it was a cylinder of height = L and radius = H, with L=466mm and H=132mm)

Does that seem correct ? Am I missing something ? Like maybe HP is not enought to determine the size of a motor ?

@sfsworms

This comment has been minimized.

Copy link

commented Jul 17, 2018

Those seems to be industrial motors, presumably weight reduction isn't really a concern for those. It seems about ok for industrial electric motors. (This has good tables of size and wieght too) http://www.steelofab.net/pdf/Hindustan-Electric-Motors-Catalogue.pdf

For comparison, a Tesla model S electric motor weight about 175 kg (https://www.quora.com/How-much-does-the-Tesla-Model-S-motor-weigh?share=1) and has a power outpout of 780 HP. Looking at the equivalent power from our hindustani friends, the biggest engine they have is 420 HP, and weight a whooping two tons.

I guess for our purpose, looking at motors of electric cars, bikes, scooter and the like probably provide the best yardstick?

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2018

So rather than trying to fit a size to a power we decide on which engine is which and estimate a size this way ?

enhanced electric motor is a like a Tesla engine : 780 HP, 175 kg and 250L Tesla Model S Drive Unit

large lectric motor is like one from a racing car : 420 HP, 90kg and 16L AM Racing AMR Dual Stack 250-90 AC Motor

electric motor standard electric car : 125HP, 68kg and 20L Curtis 1238e-7621 HPEVS Dual AC-34 (I don't know if it's really "standard" or not)

small electric motor motrobike : 15HP , 17kg and 5L BLDC / PMSM brushless motor HPM-10KW

tiny motor electric bike : 0.7HP , 5.8kg and 0.5L Front 500w Heavy-Duty Direct-Drive Motor

It seems to fit the role of each motor correctly, but I don't really have any rational to choose those models other than that's the ones I found.

And maybe we throw a micro motor on top of that for manhacks and some tools ? Could be an item just for crafting that is not a vehicle part so we don't have to assign it any power value ?

@Fris0uman Fris0uman closed this Jul 17, 2018

@Fris0uman Fris0uman reopened this Jul 17, 2018

@sfsworms

This comment has been minimized.

Copy link

commented Jul 17, 2018

They seems about right. Maybe I just think you're overestimating the size od the tesla motor since it has that "bulge" on the side. Assuming the bulg is one third of the total size, I get 108 L.

I also get something a bit bigger, around 30L, for the racing car.

The "micro motor" is also nice

@nexusmrsep

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2018

"Servomotor" maybe?

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

Well I thought about that, but servomotor are for precise movement. That doesn't seem to fit with manhack rotating blades or the motor inside a food processor. The only thing I can think of that could be using servomotor is door_motor but for only one object I don't think it's worth.

@John-Candlebury

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2018

The enhanced electric engine is more like a wheel hub motor, its just that the the vehicle rework that would have allowed them to function properly never happened to conclusion.

Notice that is both very small and lightweight and has low efficiency, the only car that includes it by the default (atomic sports car) also has them installed in the wheel tiles.

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

The enhanced electric engine is more like a wheel hub motor, its just that the the vehicle rework that would have allowed them to function properly never happened to conclusion.

If I read the jsons correclty motor_enhanced is currently 3L, 20Kg, 250HP and has "epower": -60000,
We could keep it this way, and just adjust the description to mention the wheel hub thing.

But now I realise that I have no idea how to adjust power consuption, does anybody now how epower is calculated ?

@ZhilkinSerg

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2018

Tests need to be updated.

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2018

So after a bit of testing it turns out that a 1HP motor_tiny can't move a bike with the player on it.
image

After bumping power to 5 HP top speed is still of only 6km/h, what I get from that is that it's pointless to tweak electric motor to be more "realistic" if it's making them useless in game.

So what do you guys think ? Is there a way to solve that only with json ? Or should I just close this PR and maybe try again one day when vehicle physics is reworked ?

@Fris0uman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2018

So in the end I just changed the weight and volume of the motors and added motor_micro which is a very small motor for recipes only.
Now it seems that every check is failing, how do I check what's messed up to correct it ?

Fris0uman added some commits Aug 19, 2018

Merge branch 'master' of https://github.com/CleverRaven/Cataclysm-DDA
…into More_Motor_Size

Resolve conflicts in vehicle_parts by removing the badly formatted part
Merge branch 'master' of https://github.com/CleverRaven/Cataclysm-DDA
…into More_Motor_Size

Resolve conflict with furniture.json by removing it from this branch

@Fris0uman Fris0uman changed the title More motor size : Add Tiny Motor Electric motor size revamp : Add tiny motor and micro motor Aug 19, 2018

@kevingranade

This comment has been minimized.

Copy link
Member

commented Aug 25, 2018

This PR is pretty hosed, can you copy your changes to a new branch? That seems a lot easier than trying to resolve it through git.

@Fris0uman Fris0uman referenced this pull request Aug 25, 2018

Closed

Motor size revamp #25127

@Fris0uman Fris0uman deleted the Fris0uman:More_Motor_Size branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.