Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[DONE] Remove/recover camp manager #24339
Conversation
acidia
added some commits
Jul 14, 2018
Night-Pryanik
referenced this pull request
Jul 17, 2018
Closed
The "Has seen faction camp tutorial" trait should not be visible #24342
ZhilkinSerg
merged commit 6841a5c
into
CleverRaven:master
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
acidia commentedJul 17, 2018
Addresses #24336
You can abandon a camp and recover your camp manager. Reason this wasn't included and has warnings you have to accept is that any NPCs that are away on mission can't be recovered until you reinstate a manager and you can't reinstate a manager currently because that is a pile of issues involving detecting existing camp managers; verifying the tiles you are reclaiming are an actual functional camp; ensuring the companions you send away are properly linked to the new manager; and discouraging gaming the system by assigning a manager, sending out companions, and recovering the manager until the mission is complete.
Also drops the trait to track if you've seen the tutorial... its one Y/N query that you are going to see what, 3-4 times a game? Not worth a trait to track since you may WANT to see it again as stuff changes.