[DONE] Faction Camp Upgrade Vehicle Check #24348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Random thought, maybe add a parking lot of some kind to give the player
somewhere they know is safe to park?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #24343.
The NPC was selected for return before the OM was checked to ensure that it could be upgraded. The only thing that really causes an OM to fail updating is having vehicles on the OM since allowing upgrading around vehicles is a pile of checks that aren't guaranteed to even be accurate do to all the different places vehicles are tracked and how they enter and leave the current vehicle caches. Easier to just force the player to move vehicles out between upgrades to prevent conflict.