Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[DONE] Faction Camp Upgrade Vehicle Check #24348
Conversation
acidia
added some commits
Jul 14, 2018
acidia
referenced this pull request
Jul 18, 2018
Closed
"You don't have any companions ready to return" when NPC base manager claims they are done #24343
ZhilkinSerg
self-assigned this
Jul 18, 2018
ZhilkinSerg
merged commit b6c66b9
into
CleverRaven:master
Jul 18, 2018
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
ZhilkinSerg
removed their assignment
Jul 18, 2018
This comment has been minimized.
This comment has been minimized.
|
Random thought, maybe add a parking lot of some kind to give the player
somewhere they know is safe to park?
|
mlangsdorf
added this to Done
in Faction Camp Improvements
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
acidia commentedJul 18, 2018
This should fix #24343.
The NPC was selected for return before the OM was checked to ensure that it could be upgraded. The only thing that really causes an OM to fail updating is having vehicles on the OM since allowing upgrading around vehicles is a pile of checks that aren't guaranteed to even be accurate do to all the different places vehicles are tracked and how they enter and leave the current vehicle caches. Easier to just force the player to move vehicles out between upgrades to prevent conflict.