Improve place_nested: Fuzzy neighbor matching and an else option #24431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se option.
- "chunks" are placed if neighbors match, and "else_chunks" otherwise.
- Neighbor now matches a substring ("lab" matches "ice_lab" & "lab_stairs")
This was used to fix-up lab json to better handle non-lab segments.
- We used to try to match on empty_rock to decide to place border walls.
- Now we match on "lab", and put border walls in the else place.
- As a result, we correctly handle being next to subways, ant hives, etc.
- The newly created is_ot_subtype was also used to improve the lab mapgen.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used to fix-up lab json to better handle non-lab segments.